[FIX] Skip header row when not a DDL query#31
Open
riyadhalnur wants to merge 2 commits intosegmentio:masterfrom
Open
[FIX] Skip header row when not a DDL query#31riyadhalnur wants to merge 2 commits intosegmentio:masterfrom
riyadhalnur wants to merge 2 commits intosegmentio:masterfrom
Conversation
DDL queries on Athena don't return a header row. If query contains a DDL statement, the first row is not skipped when doing a scan. Signed-off-by: Riyadh Al Nur <riyadhalnur@verticalaxisbd.com>
Author
|
This is rebased if anybody wants to take a look. cc @bhavanki |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DDL queries on Athena don't return a header row. If query contains a DDL statement, the first row is not skipped when doing a scan.
Closes #10. Thank you @Bobochka for the running code for this. I used this here but just added test case to verify.
Signed-off-by: Riyadh Al Nur riyadhalnur@verticalaxisbd.com