Merge pull request #151 from North-Two-Five/issue#Nro140-change-confu…

…sing-config-variable-name Issue#140 change confusing config variable name
segmentio · Dec 8, 2020 · af38ec1 · af38ec1
2 parents fc8ed1b + 663573d
commit af38ec1
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 16 deletions.
diff --git a/Analytics/Client.cs b/Analytics/Client.cs
@@ -62,9 +62,9 @@ internal Client(string writeKey, Config config, IRequestHandler requestHandler)
             if (requestHandler == null)
             {
                 if (config.Send)
-                    requestHandler = new FakeRequestHandler(this);
-                else
                     requestHandler = new BlockingRequestHandler(this, config.Timeout);
+                else
+                    requestHandler = new FakeRequestHandler(this);
             }
 
             IBatchFactory batchFactory = new SimpleBatchFactory(this._writeKey);

diff --git a/Analytics/Config.cs b/Analytics/Config.cs
@@ -48,7 +48,7 @@ public class Config
         /// <param name="threads">Count of concurrent internal threads to post data from queue</param>
         /// <param name="flushInterval">The frequency, in seconds, to send data to Segment</param>
         /// <param name="gzip">Compress data w/ gzip before dispatch</param>
-        /// <param name="send">Don’t send data to Segment</param>
+        /// <param name="send">Send data to Segment</param>
         /// <param name="userAgent">Sets User Agent Header</param>
         public Config(
             string host = "https://api.segment.io",
@@ -60,7 +60,7 @@ public Config(
             int threads = 1,
             double flushInterval = 10,
             bool gzip = false,
-            bool send = false,
+            bool send = true,
             string userAgent = null
             )
         {

diff --git a/Test.Net35/ClientTests.cs b/Test.Net35/ClientTests.cs
@@ -184,9 +184,9 @@ public void IdentifyThrowsInvalidOperationExceptionWhenUserIdIsEmpty()
         }
 
         [Test]
-        public void ClientUsesFakeRequestHandlerWhenSendIsTrue()
+        public void ClientUsesFakeRequestHandlerWhenSendIsFalse()
         {
-            var client = new Client("writeKey", new Config(send: true));
+            var client = new Client("writeKey", new Config(send: false));
 
             var flushHandler = GetPrivateFieldValue<AsyncIntervalFlushHandler>(client, "_flushHandler");
 
@@ -196,9 +196,9 @@ public void ClientUsesFakeRequestHandlerWhenSendIsTrue()
         }
 
         [Test]
-        public void ClientUsesBlockingRequestHandlerWhenSendIsFalse()
+        public void ClientUsesBlockingRequestHandlerWhenSendIsTrue()
         {
-            var client = new Client("writeKey", new Config(send: false));
+            var client = new Client("writeKey", new Config(send: true));
 
             var flushHandler = GetPrivateFieldValue<AsyncIntervalFlushHandler>(client, "_flushHandler");
 

diff --git a/Test.Net45/ClientTests.cs b/Test.Net45/ClientTests.cs
@@ -184,9 +184,9 @@ public void IdentifyThrowsInvalidOperationExceptionWhenUserIdIsEmpty()
         }
 
         [Test]
-        public void ClientUsesFakeRequestHandlerWhenSendIsTrue()
+        public void ClientUsesFakeRequestHandlerWhenSendIsFalse()
         {
-            var client = new Client("writeKey", new Config(send: true));
+            var client = new Client("writeKey", new Config(send: false));
 
             var flushHandler = GetPrivateFieldValue<AsyncIntervalFlushHandler>(client, "_flushHandler");
 
@@ -196,9 +196,9 @@ public void ClientUsesFakeRequestHandlerWhenSendIsTrue()
         }
 
         [Test]
-        public void ClientUsesBlockingRequestHandlerWhenSendIsFalse()
+        public void ClientUsesBlockingRequestHandlerWhenSendIsTrue()
         {
-            var client = new Client("writeKey", new Config(send: false));
+            var client = new Client("writeKey", new Config(send: true));
 
             var flushHandler = GetPrivateFieldValue<AsyncIntervalFlushHandler>(client, "_flushHandler");
 

diff --git a/Test.NetStandard20/ClientTests.cs b/Test.NetStandard20/ClientTests.cs
@@ -184,9 +184,9 @@ public void IdentifyThrowsInvalidOperationExceptionWhenUserIdIsEmpty()
         }
 
         [Test]
-        public void ClientUsesFakeRequestHandlerWhenSendIsTrue()
+        public void ClientUsesFakeRequestHandlerWhenSendIsFalse()
         {
-            var client = new Client("writeKey", new Config(send: true));
+            var client = new Client("writeKey", new Config(send: false));
 
             var flushHandler = GetPrivateFieldValue<AsyncIntervalFlushHandler>(client, "_flushHandler");
 
@@ -196,9 +196,9 @@ public void ClientUsesFakeRequestHandlerWhenSendIsTrue()
         }
 
         [Test]
-        public void ClientUsesBlockingRequestHandlerWhenSendIsFalse()
+        public void ClientUsesBlockingRequestHandlerWhenSendIsTrue()
         {
-            var client = new Client("writeKey", new Config(send: false));
+            var client = new Client("writeKey", new Config(send: true));
 
             var flushHandler = GetPrivateFieldValue<AsyncIntervalFlushHandler>(client, "_flushHandler");