Skip to content
This repository has been archived by the owner on Oct 15, 2019. It is now read-only.
Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jpreynat
Copy link

@jpreynat jpreynat commented Apr 13, 2018

This PR was made mainly to take advantage of getsentry/sentry-javascript#1253 when parsing non-Error like Objects that is a big improvement for errors debugging in Sentry.

@codecov-io
Copy link

codecov-io commented Apr 13, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@9357749). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #30   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      1           
  Lines             ?     25           
  Branches          ?      0           
=======================================
  Hits              ?     25           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
lib/index.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9357749...289e8b9. Read the comment docs.

@miketheman
Copy link

https://github.com/getsentry/raven-js/releases/tag/3.24.2 was released - let's get that one?

@mshwery
Copy link

mshwery commented May 3, 2018

Looks like the failure in CircleCI was related to rate-limited use of saucelabs for browser testing:

Uh oh, you've run out of minutes!
Please visit https://saucelabs.com/pricing to purchase a subscription.

Can someone with auth trigger a rebuild? Would love to see this get pushed through. Many older .NET projects can't use the current v3.17.0 Sentry integration version due to 'use strict' causing FireFox and IE to throw exceptions because many old .NET libraries use arguments.callee.

@atrivedi1 atrivedi1 requested a review from brennan May 4, 2018 22:44
@jesseforrest
Copy link

Any update on getting the latest SDK from Sentry into Segment?

@SegmentDestinationsBot
Copy link
Contributor

Hi @jpreynat, as part of the monorepo migration, this issue has been moved to new issue. Our engineers have been notified and will prioritize and work on it ASAP. Thank you!

For more information, see README.md.

@SegmentDestinationsBot SegmentDestinationsBot added the migrated The issue has been migrated label Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
migrated The issue has been migrated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants