This repository has been archived by the owner on Nov 23, 2019. It is now read-only.
Emit errors when the request fails #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It order for this to actually work, yields/send-json needs to be updated. A pull request has been sent yields/send-json#5.
|
@ndhoule @sperand-io @f2prateek can you guys take a look at this PR? |
|
BTW the test are failing, because I've added a test case for the new behavior. As I mentioned in the PR description, the test will fail until yields/send-json#5 gets merged and (assuming that happens) I can update the |
|
@ndhoule @sperand-io @f2prateek Any news on this? Would you need anything from us? |
gnandretta
changed the title
|
Hi @gnandretta, as part of the monorepo migration, this issue has been moved to new issue. Our engineers have been notified and will prioritize and work on it ASAP. Thank you! For more information, see README.md. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe @cristiandouce has been talking with your support team about the details of the issues we are experiencing, but we need a mechanism to detect when a request to segment (via analytics.js) fails. The callbacks that can be provided to methods like
track,page,identifyand so on, don't yield any information about the status of the request.One solution we came up with is to emit errors when the request fails and it is implemented in this pull request. Unfortunately, in order for this to actually work, yields/send-json needs to be updated. A pull request has already been sent. .