This repository has been archived by the owner on Aug 20, 2019. It is now read-only.
Map CapitalCase special properties to mixpanel #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only camel case special properties would map to their Mixpanel equivalents, eg. "name" maps to "$name" and "email" to "$email". This causes issues when a CapitalCase trait naming convention is used. This change allows for all special properties to be properly mapped to their Mixpanel equivalents, eg. "Name" to "$name" and "Email" to "$email".
|
Hi @ErikAGriffin, as part of the monorepo migration, this issue has been moved to new issue. Our engineers have been notified and will prioritize and work on it ASAP. Thank you! For more information, see README.md. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only camel case special properties would map to their Mixpanel equivalents,
eg. "name" maps to "$name" and "email" to "$email". This causes issues when a
CapitalCase trait naming convention is used. This change allows for all special properties
to be properly mapped to their Mixpanel equivalents, eg. "Name" to "$name" and "Email"
to "$email".