Skip to content
This repository has been archived by the owner on Nov 27, 2019. It is now read-only.

Gracefully fail on window.dataLayer name conflict #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Gracefully fail on window.dataLayer name conflict #15

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7cc8d5
Gracefully fail on window.dataLayer name conflict
Peripheral1994 May 25, 2018
f661ed6
Change to debug
Peripheral1994 May 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ var GTM = module.exports = integration('Google Tag Manager')
*/

GTM.prototype.initialize = function() {
// If window.dataLayer already exists and isn't an array, fail gracefully.
if (window.dataLayer && !Array.isArray(window.dataLater)) {
console.error('window.dataLayer already exists - not running Segment<>GTM destination')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do this.debug - https://github.com/segment-integrations/analytics.js-integration-bronto/blob/391bf8bbbedb7d63e1104fc4ac8821daa00a766d/lib/index.js#L37

return;
}

push({ 'gtm.start': Number(new Date()), event: 'gtm.js' });

if (this.options.environment.length) {
Expand Down