Skip to content

Conversation

@tesuji
Copy link
Contributor

@tesuji tesuji commented Nov 11, 2025

I split to original files to 2 more files to enable docker cache the debootstrap step (around 120s up to 200s).

Notes: git show main...<this branch> could highlight moved lines between files while GitHub UI could not.

@tesuji tesuji marked this pull request as draft November 11, 2025 08:57
@tesuji

This comment was marked as resolved.

@tesuji tesuji marked this pull request as ready for review November 11, 2025 09:00
@tesuji tesuji marked this pull request as draft November 11, 2025 09:21
@tesuji tesuji marked this pull request as ready for review November 11, 2025 09:36
@tesuji tesuji force-pushed the img-container branch 2 times, most recently from 47ba63d to 61a34ca Compare November 12, 2025 07:10
@Kyle-Kyle
Copy link
Collaborator

thanks for the PR.
I think creating the disk image in a docker container is a good idea. But splitting the create_image.sh script into multiple ones is not necessary, especially when some of them may potentially cause issues.
For example, if a user accidentally executes the configure.sh file, their machine may get corrupted. Even though it is not a scenario likely to happen, I'd rather not have this risk in the repo.

@tesuji
Copy link
Contributor Author

tesuji commented Nov 13, 2025

That's a valid concern. I will add a magic env var and only execute configure.sh if that var presents.

Also use the archive link for `debootstrap` to avoid EOL links.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants