-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix responsive issue in scholarx/past-programs card-deck #1628
Conversation
…justing CSS for proper padding and row-gap between cards. Bug fix for issue sef-global#1627 . Resolved responsive issues in the scholarx/past-programs card deck. Adjusted CSS to ensure proper padding and row-gap between cards for mobile and tablet views. The section is now responsive across various screen sizes. Bug fix for issue sef-global#1627 .
Co-authored-by: Yoshitha Rathnayake <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the preview link? @mkskaushalya
You should include the pr number except this {PR_NUMBER}
Ex: https://pr-0000-sef-site.surge.sh/
Add the directory also /scholarx/past-programs/
Changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you able to fix this size issue? @mkskaushalya its not same in the bottom row, can you make it like the size (height) of the top row?
Co-authored-by: Yoshitha Rathnayake <[email protected]>
OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Thank you @mkskaushalya
Purpose
The purpose of this PR is to fix #1627
Goals
The goal is to ensure that the scholarx/past-programs card deck is responsive across various screen sizes, with proper padding and row-gap between cards.
Approach
I adjusted the CSS for the card deck section to improve responsiveness. Flexbox properties were modified to include appropriate padding and row-gap for mobile and tablet views.
Screenshots
Preview Link
https://pr-1628-sef-site.surge.sh/scholarx/past-programs/#past-scholarx
Checklist
Related PRs
N/A
Learning
During the implementation, I referred to the development best practices and made use of CSS flexbox properties to enhance responsiveness.