Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix responsive issue in scholarx/past-programs card-deck #1628

Merged
merged 12 commits into from
May 14, 2024

Conversation

mkskaushalya
Copy link
Contributor

@mkskaushalya mkskaushalya commented May 14, 2024

Purpose

The purpose of this PR is to fix #1627

Goals

The goal is to ensure that the scholarx/past-programs card deck is responsive across various screen sizes, with proper padding and row-gap between cards.

Approach

I adjusted the CSS for the card deck section to improve responsiveness. Flexbox properties were modified to include appropriate padding and row-gap for mobile and tablet views.

Screenshots

image

image

Preview Link

https://pr-1628-sef-site.surge.sh/scholarx/past-programs/#past-scholarx

Checklist

Related PRs

N/A

Learning

During the implementation, I referred to the development best practices and made use of CSS flexbox properties to enhance responsiveness.

…justing CSS for proper padding and row-gap between cards. Bug fix for issue sef-global#1627 .

Resolved responsive issues in the scholarx/past-programs card deck. Adjusted CSS to ensure proper padding and row-gap between cards for mobile and tablet views. The section is now responsive across various screen sizes. Bug fix for issue sef-global#1627 .
Co-authored-by: Yoshitha Rathnayake <[email protected]>
CNAME Outdated Show resolved Hide resolved
@YoshithaRathnayake YoshithaRathnayake changed the title Fix responsive issue in scholarx/past-programs card-deck #1627 Fix responsive issue in scholarx/past-programs card-deck May 14, 2024
Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

Can you increase the padding little bit like in the earlier one and the font size too @mkskaushalya

@mkskaushalya
Copy link
Contributor Author

image

image

Can you increase the padding little bit like in the earlier one and the font size too @mkskaushalya

Done

Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the preview link? @mkskaushalya
You should include the pr number except this {PR_NUMBER}
Ex: https://pr-0000-sef-site.surge.sh/

Add the directory also /scholarx/past-programs/

@mkskaushalya
Copy link
Contributor Author

Can you update the preview link? @mkskaushalya You should include the pr number except this {PR_NUMBER} Ex: https://pr-0000-sef-site.surge.sh/

Add the directory also /scholarx/past-programs/

Changed

Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Would you able to fix this size issue? @mkskaushalya its not same in the bottom row, can you make it like the size (height) of the top row?

Co-authored-by: Yoshitha Rathnayake <[email protected]>
@mkskaushalya
Copy link
Contributor Author

image

Would you able to fix this size issue? @mkskaushalya its not same in the bottom row, can you make it like the size (height) of the top row?

OK.

Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Thank you @mkskaushalya

@YoshithaRathnayake YoshithaRathnayake merged commit 51fcaba into sef-global:master May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsive issue in scholarx/past-programs card-deck
2 participants