Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blog cards template as interactive with hover #1623

Merged
merged 1 commit into from
May 12, 2024

Conversation

ifhammohamed
Copy link
Contributor

@ifhammohamed ifhammohamed commented May 11, 2024

Purpose

The purpose of this PR is to fix #1591

Goals

  • Solve the images appear stretched
  • Enhance the interactivity of the blog posts card

Approach

  • improved the image style using object-fit , overflow and, img-thumbnail
  • enhance the interactivity by hover effect

Screenshots

issue.1591.fixed.mp4

Preview Link

https://pr-1623-sef-site.surge.sh/

Checklist

  • I have read and understood the development best practices guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I created a fork from the master branch and made my changes in to that same master branch
  • My pull request is sent to the correct base branch in the original repo
  • I have linked the issue I worked on to this pull request submitted by me
  • File(s) or folder(s) now contain changes as specified in the issue i worked on
  • I certify that I ran my checklist.

Related PRs

Learning

@ifhammohamed
Copy link
Contributor Author

Hi @anjula-sack This PR is ready for review.

Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!, good for me @ifhammohamed1111
How about @anjula-sack ?

@YoshithaRathnayake YoshithaRathnayake changed the title Update blog cards template as interactive with hover [#1591] Update blog cards template as interactive with hover May 11, 2024
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loos good! @ifhammohamed1111 Can you drop a comment on the issue? Usually you have to get assigned for an issue and then you send a PR

@anjula-sack anjula-sack merged commit 156708c into sef-global:master May 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the images on the blog cards
3 participants