Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bugs in the footer in the mobile view #1209

Closed

Conversation

YoshithaRathnayake
Copy link
Member

@YoshithaRathnayake YoshithaRathnayake commented Aug 7, 2022

Purpose

The purpose of this PR is to fix #1207

Goals

Fixing the bugs in the footer in the mobile view

Approach

I fixed the bugs in the footer in the mobile view

Screenshots

At the resolution < 991

Before

image

After

image

At the resolution < 458

Before

image

After

image

Preview Link

https://pr-1209-sef-site.surge.sh/

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show the year and SEF part at the bottom after the footer.

@YoshithaRathnayake YoshithaRathnayake marked this pull request as draft August 9, 2022 13:47
@anjula-sack
Copy link
Member

@YoshithaRathnayake Any updates on this?

@YoshithaRathnayake
Copy link
Member Author

YoshithaRathnayake commented Oct 2, 2022

@YoshithaRathnayake Any updates on this?

Nope forgot to remove the draft @anjula-sack

@YoshithaRathnayake YoshithaRathnayake marked this pull request as ready for review October 2, 2022 13:28
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the desktop view is messed up.
image

@YoshithaRathnayake
Copy link
Member Author

Ok @anjula-sack done!

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still different
image

@Piumal1999
Copy link
Member

It will be easier if we use bootstrap classes instead of writing css media queries for every edge case.

@YoshithaRathnayake
Copy link
Member Author

It will be easier if we use bootstrap classes instead of writing css media queries for every edge case.

Yes I am thinking to undo this changes and redo them with the changes requested. Is it ok @Piumal1999 , @anjula-sack

@anjula-sack
Copy link
Member

It will be easier if we use bootstrap classes instead of writing css media queries for every edge case.

Yes I am thinking to undo this changes and redo them with the changes requested. Is it ok @Piumal1999 , @anjula-sack

sure, I'll make this draft until that.

@anjula-sack anjula-sack marked this pull request as draft October 5, 2022 01:58
@YoshithaRathnayake
Copy link
Member Author

It will be easier if we use bootstrap classes instead of writing css media queries for every edge case.

Yes I am thinking to undo this changes and redo them with the changes requested. Is it ok @Piumal1999 , @anjula-sack

sure, I'll make this draft until that.

so I think to close this pr and do this again with bootstrap. Is it ok @anjula-sack

@anjula-sack
Copy link
Member

It will be easier if we use bootstrap classes instead of writing css media queries for every edge case.

Yes I am thinking to undo this changes and redo them with the changes requested. Is it ok @Piumal1999 , @anjula-sack

sure, I'll make this draft until that.

so I think to close this pr and do this again with bootstrap. Is it ok @anjula-sack

yeah sure no worries.

@YoshithaRathnayake
Copy link
Member Author

@anjula-sack is it ok if I do this in custom css bcs I can't understand to do this in bootstrap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the bugs in the footer in the mobile view
3 participants