-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the bugs in the footer in the mobile view #1209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Show the year and SEF part at the bottom after the footer.
@YoshithaRathnayake Any updates on this? |
Nope forgot to remove the draft @anjula-sack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok @anjula-sack done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be easier if we use bootstrap classes instead of writing css media queries for every edge case. |
Yes I am thinking to undo this changes and redo them with the changes requested. Is it ok @Piumal1999 , @anjula-sack |
sure, I'll make this draft until that. |
so I think to close this pr and do this again with bootstrap. Is it ok @anjula-sack |
yeah sure no worries. |
@anjula-sack is it ok if I do this in custom css bcs I can't understand to do this in bootstrap |
Purpose
The purpose of this PR is to fix #1207
Goals
Fixing the bugs in the footer in the mobile view
Approach
I fixed the bugs in the footer in the mobile view
Screenshots
Before
After
Before
After
Preview Link
https://pr-1209-sef-site.surge.sh/
Checklist
Related PRs
Test environment
Learning