Add tailwind to mainLayOut and NavBar #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add tailwind branch |
anjula-sack
requested changes
Jan 31, 2024
src/components/Layout/MainLayout.tsx
Outdated
| @@ -3,7 +3,7 @@ import React, { type ReactNode } from 'react'; | |||
| import { Layout } from 'antd'; | |||
|
|
|||
| import FooterComponent from './Footer/Footer'; | |||
| import styles from './MainLayout.module.css'; | |||
| // import styles from './MainLayout.module.css'; | |||
There was a problem hiding this comment.
Suggested change
| // import styles from './MainLayout.module.css'; |
| </a> | ||
| <a href="" target="_blank" rel="noreferrer"> | ||
| <Text className={styles.antTypography}>Join Us</Text> | ||
| <Text className="antTypography text-primary text-[14px] font-light">Join Us</Text> |
There was a problem hiding this comment.
Use a standard size like text-sm text-md
tailwind.config.js
Outdated
| @@ -4,6 +4,8 @@ export const theme = { | |||
| extend: { | |||
| colors: { | |||
| 'primary-blue': '#1677FF', | |||
| 'ant-icon-color': '#525F7F', | |||
There was a problem hiding this comment.
Lets use a different name here without the ant part
Suggested change
| 'ant-icon-color': '#525F7F', | |
| 'ant-icon-color': '#525F7F', |
anjula-sack
changed the title
|
@kavinda-100 There are some conflicts can you fix them? |
|
@kavinda-100 There are some conflicts can you fix them as well? |
|
done the required changes |
|
@kavinda-100 The conflicts are still there |
anjula-sack
requested changes
Mar 2, 2024
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The Navbar is not responsive when resizing the browser window.
(#73)
Goals
add tailwindcss utility classes to MainLayOut and NavBar to fix the issue.
Approach
I had set the max width to the nav bar and added proper Tailwind classes according to the device breakpoints to achieve responsiveness for the NavBar.
Screenshots
#73 (comment)
Checklist
Related PRs
Test environment
Learning