Implement Automatic remainder sending email service #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of directly passing individual fields to the updateProfile function, refactor the logic to use a single updateData object. This object contains the updated fields for the profile, such as primary_email, first_name, last_name, and image_url. This change improves code readability and maintainability. Related to sef-global#165
- Moved monthly checking service functions to a dedicated service file (monthlyChecking.service.ts). - Moved monthly checking controller functions to a dedicated controller file (monthlyChecking.controller.ts). - Updated import paths and references to reflect the new file structure. - Improved code organization and maintainability by separating concerns.
Monthly checking feature
mayura-andrew
changed the title
anjula-sack
requested changes
Oct 27, 2024
| @@ -10,7 +10,6 @@ import { | |||
| capitalizeFirstLetter | |||
| } from '../utils' | |||
| import { sendEmail } from './admin/email.service' | |||
|
|
|||
| } | ||
|
|
||
| private async getPendingAttempts(): Promise<ReminderAttempt[]> { | ||
| console.log('Fetching pending attempts') |
There was a problem hiding this comment.
Suggested change
| console.log('Fetching pending attempts') |
…mpts, introduce new mentee reminders logic
anjula-sack
requested changes
Oct 31, 2024
| this.configRepository = dataSource.getRepository(MenteeReminderConfig) | ||
| this.menteeRepository = dataSource.getRepository(Mentee) | ||
| this.attemptRepository = dataSource.getRepository(ReminderAttempt) | ||
| console.log('EmailReminderService initialized') |
There was a problem hiding this comment.
Suggested change
| console.log('EmailReminderService initialized') |
There was a problem hiding this comment.
I'll remove these console.logs
| res: Response | ||
| ): Promise<void> => { | ||
| try { | ||
| res.status(200).json({ message: 'Reminder enabled' }) |
There was a problem hiding this comment.
What is the purpose of this?
There was a problem hiding this comment.
this is a API endpoint but not implemented yet. I'll implement this soon as possible :)
… for processing and scheduling reminders, and enhance reminder service logic
anjula-sack
requested changes
Nov 1, 2024
package.json
Outdated
| "dotenv": "^16.3.1", | ||
| "ejs": "^3.1.10", | ||
| "express": "^4.18.2", | ||
| "jsonwebtoken": "^9.0.2", | ||
| "multer": "^1.4.5-lts.1", | ||
| "node-cron": "^3.0.3", |
There was a problem hiding this comment.
Remove this if not required
Suggested change
| "node-cron": "^3.0.3", |
| @@ -56,6 +58,7 @@ | |||
| "@types/jsonwebtoken": "^9.0.2", | |||
| "@types/multer": "^1.4.11", | |||
| "@types/node": "^20.1.4", | |||
| "@types/node-cron": "^3.0.11", | |||
There was a problem hiding this comment.
Suggested change
| "@types/node-cron": "^3.0.11", |
… status enums, and implement dynamic next reminder date calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #176
This issue involves enhancing the
EmailReminderServiceto ensure that email reminders are scheduled and processed correctly, with proper handling of retries and failures.Goals
Approach
EmailRemindersentity to initialize properties correctly.processRemindersmethod to handle pending reminders, including retries and exponential backoff.scheduleRemindersmethod.Screenshots
Checklist
Related PRs
Test environment
Learning