[MP-1010] Fix ampersand in email_subject_room_name

seekingalpha · Oct 25, 2020 · e4c4b1c · e4c4b1c
1 parent 10af010
commit e4c4b1c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app/lib/server/functions/notifications/email.js b/app/lib/server/functions/notifications/email.js
@@ -134,7 +134,7 @@ export function getEmailData({
 	const emailSubject = Mailer.replace(settings.get(subjectKey), {
 		user: username,
 		room: roomTypes.getRoomName(room.t, room),
-	});
+	}, ['room']);
 	const content = getEmailContent({
 		message,
 		user: receiver,

diff --git a/app/mailer/server/api.js b/app/mailer/server/api.js
@@ -23,9 +23,9 @@ settings.get('Language', (key, value) => {
 	lng = value || 'en';
 });
 
-export const replacekey = (str, key, value = '') => str.replace(new RegExp(`(\\[${ key }\\]|__${ key }__)`, 'igm'), s.escapeHTML(value));
+export const replacekey = (str, key, value = '', nonEscapeKeys = []) => str.replace(new RegExp(`(\\[${ key }\\]|__${ key }__)`, 'igm'), nonEscapeKeys && nonEscapeKeys.includes(key) ? value : s.escapeHTML(value));
 export const translate = (str) => str.replace(/\{ ?([^\} ]+)(( ([^\}]+))+)? ?\}/gmi, (match, key) => TAPi18n.__(key, { lng }));
-export const replace = function replace(str, data = {}) {
+export const replace = function replace(str, data = {}, nonEscapeKeys = []) {
 	if (!str) {
 		return '';
 	}
@@ -39,7 +39,7 @@ export const replace = function replace(str, data = {}) {
 		},
 		...data,
 	};
-	return Object.entries(options).reduce((ret, [key, value]) => replacekey(ret, key, value), translate(str));
+	return Object.entries(options).reduce((ret, [key, value]) => replacekey(ret, key, value, nonEscapeKeys), translate(str));
 };
 
 const nonEscapeKeys = ['room_path'];