PATCH: Increase the OEmbed sizeLimit from 250 KB to 1 MB #69
nmagedmanci.yml
on: push
⚙️ Variables Setup
2s
🚀 Notify external services - draft
0s
Matrix: 🔎 Code Check / code-check
Matrix: 🚢 Build Docker Images for Testing
Matrix: 🔨 Test API (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test API (CE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (CE) / test
Waiting for pending jobs
Matrix: 🚀 Publish Docker Image (services)
Matrix: 🚀 Publish Docker Image (main)
🚀 Notify external services
0s
trigger-dependent-workflows
0s
Matrix: 🚢 Build Docker Images for Production
Annotations
13 errors and 18 warnings
|
🔎 Code Check / Code Lint:
apps/meteor/app/file-upload/server/lib/requests.ts#L4
There should be at least one empty line between import groups
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/file-upload/server/lib/requests.ts#L5
`@rocket.chat/logger` import should occur before import of `@rocket.chat/models`
|
|
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/oembed/server/server.ts#L104
Replace `(process.env.SPEAKEASY_HTTP_HEADER_NAME·&&·process.env.SPEAKEASY_HTTP_HEADER_VALUE)` with `process.env.SPEAKEASY_HTTP_HEADER_NAME·&&⏎↹↹process.env.SPEAKEASY_HTTP_HEADER_VALUE`
|
|
🔎 Code Check / Code Lint
@rocket.chat/meteor#lint: command (/home/runner/work/Rocket.Chat/Rocket.Chat/apps/meteor) /tmp/xfs-938cfa2a/yarn run lint exited (1)
|
|
🔎 Code Check / Code Lint
Process completed with exit code 1.
|
|
🔎 Code Check / TypeScript
@rocket.chat/meteor#typecheck: command (/home/runner/work/Rocket.Chat/Rocket.Chat/apps/meteor) /tmp/xfs-504f145b/yarn run typecheck exited (2)
|
|
🔎 Code Check / TypeScript
Property 'queryParams' does not exist on type 'Operations<never, { authRequired: true; }>'.
|
|
🔎 Code Check / TypeScript
Type '{ 'User-Agent': string; 'Accept-Language': string | number | true | Date | SettingValueMultiSelect | SettingValueRoomPick | AssetValue; }' is not assignable to type 'HeadersInit | undefined'.
|
|
🔎 Code Check / TypeScript
A computed property name must be of type 'string', 'number', 'symbol', or 'any'.
|
|
🔎 Code Check / TypeScript
Type '() => Promise<{ success: boolean; } | { avatarETag?: string | undefined; } | null | undefined>' is not assignable to type '() => Promise<{ success: boolean; } | null | undefined>'.
|
|
🔎 Code Check / TypeScript
No overload matches this call.
|
|
🔎 Code Check / TypeScript
Process completed with exit code 2.
|
|
⚙️ Variables Setup
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Bhacaz/checkout-files@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
📦 Build Packages
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
🔨 Test Unit / Unit Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/[email protected], codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
📦 Meteor Build - coverage
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/[email protected], actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
🚀 Copy to S3
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Bhacaz/checkout-files@v2, actions/download-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
🔎 Code Check / Code Lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
🔎 Code Check / Code Lint:
packages/fuselage-ui-kit/jest.setup.ts#L4
Do not use "@ts-ignore" because it alters compilation errors
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/lib/server/lib/debug.js#L83
Consider using the native Array.prototype.forEach() or Object.entries().forEach()
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/lib/server/oauth/oauth.js#L42
Consider using the native Array.prototype.includes()
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/lib/server/startup/rateLimiter.js#L65
Consider using the native Array.prototype.forEach() or Object.entries().forEach()
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/markdown/lib/hljs.js#L10
Async arrow function has a complexity of 173. Maximum allowed is 31
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts#L81
Static async method 'insertOrUpdateSAMLUser' has a complexity of 32. Maximum allowed is 31
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/reactions/client/init.ts#L32
Forbidden non-null assertion
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/threads/client/messageAction/replyInThread.ts#L24
Forbidden non-null assertion
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/utils/lib/restrictions.ts#L9
Consider using the native Array.prototype.map()
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/utils/lib/restrictions.ts#L20
Consider using the native Array.prototype.map()
|
|
🔎 Code Check / TypeScript
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "build".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
build
Expired
|
298 MB |
|