Skip to content

PATCH: Increase the OEmbed sizeLimit from 250 KB to 1 MB #67

PATCH: Increase the OEmbed sizeLimit from 250 KB to 1 MB

PATCH: Increase the OEmbed sizeLimit from 250 KB to 1 MB #67

Triggered via push June 10, 2024 13:51
Status Success
Total duration 8m 30s
Artifacts 1

ci.yml

on: push
⚙️ Variables Setup
3s
⚙️ Variables Setup
📦 Build Packages
49s
📦 Build Packages
🚀 Notify external services - draft
0s
🚀 Notify external services - draft
Matrix: 🔎 Code Check / code-check
📦 Meteor Build - coverage
5m 29s
📦 Meteor Build - coverage
🔨 Test Unit  /  Unit Tests
1m 20s
🔨 Test Unit / Unit Tests
Matrix: 🚢 Build Docker Images for Testing
🚀 Copy to S3
25s
🚀 Copy to S3
🚢 Build Docker Image (preview)
0s
🚢 Build Docker Image (preview)
Matrix: 🔨 Test API (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test API (CE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (CE) / test
Waiting for pending jobs
Matrix: 🚀 Publish Docker Image (services)
Matrix: 🚀 Publish Docker Image (main)
✅ Tests Done
0s
✅ Tests Done
🚀 Notify external services
0s
🚀 Notify external services
trigger-dependent-workflows
0s
trigger-dependent-workflows
📦 Meteor Build - official
0s
📦 Meteor Build - official
Matrix: 🚢 Build Docker Images for Production
Fit to window
Zoom out
Zoom in

Annotations

13 errors and 18 warnings
🔎 Code Check / TypeScript
Property 'queryParams' does not exist on type 'Operations<never, { authRequired: true; }>'.
🔎 Code Check / TypeScript
@rocket.chat/meteor#typecheck: command (/home/runner/work/Rocket.Chat/Rocket.Chat/apps/meteor) /tmp/xfs-8c70d58c/yarn run typecheck exited (2)
🔎 Code Check / TypeScript
Type '{ 'User-Agent': string; 'Accept-Language': string | number | true | Date | SettingValueMultiSelect | SettingValueRoomPick | AssetValue; }' is not assignable to type 'HeadersInit | undefined'.
🔎 Code Check / TypeScript
A computed property name must be of type 'string', 'number', 'symbol', or 'any'.
🔎 Code Check / TypeScript
Type '() => Promise<{ success: boolean; } | { avatarETag?: string | undefined; } | null | undefined>' is not assignable to type '() => Promise<{ success: boolean; } | null | undefined>'.
🔎 Code Check / TypeScript
No overload matches this call.
🔎 Code Check / TypeScript
Process completed with exit code 2.
🔎 Code Check / Code Lint
@rocket.chat/meteor#lint: command (/home/runner/work/Rocket.Chat/Rocket.Chat/apps/meteor) /tmp/xfs-70009def/yarn run lint exited (1)
🔎 Code Check / Code Lint: apps/meteor/app/file-upload/server/lib/requests.ts#L4
There should be at least one empty line between import groups
🔎 Code Check / Code Lint: apps/meteor/app/file-upload/server/lib/requests.ts#L5
`@rocket.chat/logger` import should occur before import of `@rocket.chat/models`
🔎 Code Check / Code Lint: apps/meteor/app/oembed/server/server.ts#L104
Replace `(process.env.SPEAKEASY_HTTP_HEADER_NAME·&&·process.env.SPEAKEASY_HTTP_HEADER_VALUE)` with `process.env.SPEAKEASY_HTTP_HEADER_NAME·&&⏎↹↹process.env.SPEAKEASY_HTTP_HEADER_VALUE`
🔎 Code Check / Code Lint
Process completed with exit code 1.
⚙️ Variables Setup
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Bhacaz/checkout-files@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
📦 Build Packages
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
🔨 Test Unit / Unit Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/[email protected], codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
🔎 Code Check / TypeScript
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
📦 Meteor Build - coverage
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/[email protected], actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
🚀 Copy to S3
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Bhacaz/checkout-files@v2, actions/download-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
🔎 Code Check / Code Lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
🔎 Code Check / Code Lint: packages/livechat/src/components/Composer/index.tsx#L29
Prefer using an optional chain expression instead, as it's more concise and easier to read
🔎 Code Check / Code Lint: apps/meteor/app/api/server/v1/settings.ts#L109
Prefer using an optional chain expression instead, as it's more concise and easier to read
🔎 Code Check / Code Lint: apps/meteor/app/apps/server/bridges/listeners.js#L10
Arrow function has a complexity of 40. Maximum allowed is 31
🔎 Code Check / Code Lint: apps/meteor/app/apps/server/bridges/persistence.ts#L92
Prefer using an optional chain expression instead, as it's more concise and easier to read
🔎 Code Check / Code Lint: apps/meteor/app/apps/server/bridges/rooms.ts#L82
Prefer using an optional chain expression instead, as it's more concise and easier to read
🔎 Code Check / Code Lint: apps/meteor/app/apps/server/bridges/rooms.ts#L94
Prefer using an optional chain expression instead, as it's more concise and easier to read
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "build". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
build Expired
288 MB