Skip to content

Conversation

@fbacall
Copy link
Contributor

@fbacall fbacall commented Nov 7, 2025

Fixes #2300 for real this time

@fbacall fbacall requested a review from Copilot November 7, 2025 10:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where DOI minting was incorrectly blocked when assets had non-SEEK creators (unregistered creators via assets_creators) but no registered SEEK creators. The validation now properly accepts either type of creator.

  • Updated validation logic in mint_doi to check assets_creators for models that support it, falling back to creators otherwise
  • Added test coverage to verify DOI minting succeeds with non-SEEK creators present
  • Enhanced existing test to verify both creators and assets_creators are empty in the error case

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/seek/doi/acts_as_doi_mintable.rb Modified creator validation to check assets_creators if available, matching the pattern already used in datacite_metadata
test/integration/doi_minting_test.rb Added test for non-SEEK creator DOI minting and assertion to verify both creator types in existing test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fbacall fbacall merged commit cf3def6 into seek-1.17 Nov 10, 2025
25 checks passed
@fbacall fbacall deleted the allow-doi-if-non-seek-creators branch November 10, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants