-
Notifications
You must be signed in to change notification settings - Fork 2
New homepage, get-seek page, no About menu, new external link icon, other cleanups #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to manually add the .external
class, which is error prone, and also remove text about virtual machines
_sass/_custom_classes.scss
Outdated
// content: "↗️"; | ||
//} | ||
/* Add an indicator after external links that'll open in a new window. */ | ||
.external::after { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depending on what version of boostrap we're using, might be able to use the glyphicon-new-window, content: '\e164'
, or import them separately.
if it doesn't work leave it like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, I couldn't get these classes to show any icons (glyphicon-new-window or related).
We have Bootstrap 5.3.3 (the latest ETT version, anyway). Strangely I can get some new features to work (eg link-opacity) but not icon-link. https://getbootstrap.com/docs/5.3/helpers/icon-link/
contacting-us.md
Outdated
|
||
## Contact FAIRDOM | ||
For any questions and suggestions related to FAIRDOM projects, tools, standards and events please visit the [FAIRDOM contact us page](https://fair-dom.org/contact){:.external}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is some javascript that detects external links that should open in a new window. This could add the .external
class for consistency - https://github.com/seek4science/seek-documentation/blob/main/assets/js/main.js#L19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's much better. I've now replaced all the explicit mention of .external
with one more line of javascript that adds the class where you suggested.
index.md
Outdated
<div class="col d-grid"> | ||
<a role="button" class="btn py-3 fs-4 section-title" href="{{ site.baseurl }}/help/user-guide/api"><b>API Introduction</b></a> | ||
<a role="button" class="btn py-3 fs-4 section-title" href="{{ site.baseurl }}/get-seek"><h3 class=""><i class="fa-solid fa-magnifying-glass-chart fa-1x"></i> Get FAIRDOM-SEEK</h3> | ||
<p>Find out how to install FAIRDOM-SEEK on your own machine or as a virtual machine.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop the text or as a virtual machine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very nice! I just added a couple of remarks, mainly on the home page and contact-us page.
index.md
Outdated
@@ -1,85 +1,48 @@ | |||
--- | |||
sidebar: false | |||
title: FAIRDOM-SEEK Documentation | |||
title: Welcome to the FAIRDOM-SEEK Documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of the long title. On a mobile screen, it becomes easily a two line title.
<i class="fa-solid fa-flask-vial fa-1x"></i> <i class="fa-solid fa-magnifying-glass-chart fa-1x"></i> | ||
About FAIRDOM-SEEK | ||
</h2> | ||
## About FAIRDOM-SEEK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove the subtitle. I think it's fine if this paragraph is directly folowing the site title.
## About FAIRDOM-SEEK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, it would look better without this subtitle. The consequence is that the page navigation (right side) becomes just one item, 'Getting started' (or whatever text we change that subheading to). Is that okay?
Alternative, remove both subheadings... but then the page becomes full width, no left sidebar, no right page nav. I think we need something on one side. Any other ideas, anybody?
redirect_from: "/contacting_us.html" | ||
--- | ||
|
||
<i class="fa-solid fa-envelopes-bulk fa-5x"></i> | ||
We have a number of ways you can contact us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's too little content on this topic to have its own page. Can we incorporate this on another page? Maybe the Home page? Or maybe the user guide's index page, under 'Contributing'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see... Currently, we have a link to the contact-us
page in the following places:
- Footer on every page
help/user-guide/create-sample-type
tech/contributing
tech/contributing-to-seek
tech/reporting-bugs-and-features
tech/contributing-to-pages
cookies.html
- ...and the contact-us page itself
And the contact-us page in this PR contains two blocks:
- Contact the FAIRDOM community -->
fair-dom.org/contact
- Report bugs and feature requests -->
tech/reporting-bugs-and-features
The second block is circular and may be unnecessary, so yes, maybe we can just have the first block somewhere else. I think the most suitable place is tech/contributing
since we already have a little more overlap there (the email address is repeated, for example). So how would that look?
Page | Change |
---|---|
Footer on every page | replace link to fair-dom.org/contact |
help/user-guide/create-sample-type |
replace link to fair-dom.org/contact |
tech/contributing |
add paragraph and link to fair-dom.org/contact |
tech/contributing-to-seek |
replace link to fair-dom.org/contact |
tech/reporting-bugs-and-features |
replace link to fair-dom.org/contact |
tech/contributing-to-pages |
replace link to fair-dom.org/contact |
cookies.html |
Page to be removed |
contact-us |
Page redirect to fair-dom.org/contact |
I'm going back and forth a bit with this one! Perhaps discuss at tech call? (Sorry I can't be there this week, I'm in Scotland). I would prefer to have this decided/agreed before I do the work.
Mostly OK for me. Just one remark: for "Getting FAIRDOM-SEEK". The tile description only mentions how to install the software, while the actual page then also tells you that you can use a deployed instance; it needs to be coherent. Then about this, the sentence should be just "... use one of the public instance + link to https://fair-dom.org/fairdom-in-use/ " (no specific mention of FAIRDOMHub).
I am not sure. It seems a bit of a mix of things SEEK uses (java tools...) and projects that use SEEK (WorkflowHub). It seems to belong to the FAIRDOM-SEEK website or in About FAIRDOM-SEEK.
Since all DataHub development is in FAIRDOM-SEEK, I'd say we would not need a custom credit page, we can use the FAIRDOM-SEEK one. For listing projects that use FAIRDOM-SEEK as DataHub, we would use the FAIRDOM website or DataHub About page or something.
The FAIRDOM-SEEK website seems the most appropriate place. Maybe having a link to that from this doc.
OK
I do not think so. Useful links sound like "miscellaneous", so not very important. Could this links be placed in the right sections? Or maybe Quick start or something, somewhere. Not sure.
There are many internal links to the documentation. Maybe a link to the SEEK GitHub repo or SEEK slack channel?
Maybe a bit too long. FAIRDOM-SEEK Documentation should be enough. |
In general, when in doubts we could go back to the purpose of each resource:
|
Replaces PR #39, addresses part of issue #42. Also adds external link icon eg Markdown
{:.external}
with inline SVG and CSS.Homepage much cleaner, with clearly explained panels that change colour on mouse-over.

Get SEEK page also cleaner, replacing the 'About' top nav/sidebar item, with tiles.

Technical References renamed Technical Guide.

Simpler footer, less repetition.

Contacting Us page points users to the FAIRDOM Contact page.

Credits page is no longer in the menus.
Questions: