Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installer: make chart url configureble #127

Open
wants to merge 2 commits into
base: release-1.0.gamma
Choose a base branch
from
Open

installer: make chart url configureble #127

wants to merge 2 commits into from

Conversation

sallyom
Copy link
Collaborator

@sallyom sallyom commented Dec 11, 2023 •
edited
Loading

This is to enable installing from developer version of OCI chart, for example:

helm package charts/trusted-artifact-signer
helm push oci://quay.io/sallyom
./tas-install install --chart-location oci://quay.io/sallyom/trusted-artifact-signer

Also, adds initial docs on the install binary

@sallyom sallyom mentioned this pull request Dec 11, 2023
Merged
JasonPowr
JasonPowr approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@JasonPowr JasonPowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Changes look good, the docs will be super useful :)

@sallyom
Copy link
Collaborator Author

sallyom commented Dec 12, 2023

/hold this until the Dockerfile PR merges! I'll then update the docs accordingly here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonPowr JasonPowr JasonPowr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sallyom @JasonPowr