Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SECURESIGN-1207: fix SBJ breaking on update #502

Merged
merged 1 commit into from
Jul 15, 2024
Merged

SECURESIGN-1207: fix SBJ breaking on update #502

merged 1 commit into from
Jul 15, 2024

Conversation

JasonPowr
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 10, 2024 •
edited by openshift-ci bot
Loading

@JasonPowr: This pull request references SECURESIGN-1207 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JasonPowr JasonPowr force-pushed the fix-sbj-upgrade-issue branch 2 times, most recently from 91a470c to 6072559 Compare July 11, 2024 10:57
@JasonPowr JasonPowr requested a review from osmman July 12, 2024 13:18
@JasonPowr JasonPowr requested a review from osmman July 15, 2024 07:32
@openshift-ci openshift-ci bot added the lgtm label Jul 15, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JasonPowr, osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JasonPowr JasonPowr merged commit 2b82655 into main Jul 15, 2024
12 of 13 checks passed
@osmman osmman deleted the fix-sbj-upgrade-issue branch July 16, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osmman osmman osmman approved these changes

@cooktheryan cooktheryan Awaiting requested review from cooktheryan

@sallyom sallyom Awaiting requested review from sallyom

Assignees

@osmman osmman

Labels
approved jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JasonPowr @openshift-ci-robot @osmman