Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SECURESIGN 12 | Enable Podman build for TUF server image #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SECURESIGN 12 | Enable Podman build for TUF server image #1

wants to merge 1 commit into from

Conversation

Gregory-Pereira
Copy link

Attempts to Address [SECURESIGN-12].

Not sure if there is a cleaner / better implementation strategy.

/cc @saber1041
/cc @sallyom

@Gregory-Pereira Gregory-Pereira force-pushed the midstream-enable-tuf-server-podman-deployment branch 3 times, most recently from 9e8f181 to a03eeb3 Compare August 29, 2023 18:55
sabre1041
sabre1041 approved these changes Aug 30, 2023
View reviewed changes
Copy link

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gregory-Pereira
Copy link
Author

Has been removed from TP1,
/hold

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gregory-Pereira Gregory-Pereira changed the base branch from main to redhat-v0.6.5 November 16, 2023 03:24
@Gregory-Pereira
Copy link
Author

/retest tide

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 16, 2023

@Gregory-Pereira: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test test

Use /test all to run all jobs.

In response to this:

/retest tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gregory-Pereira
Copy link
Author

/test tide

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 16, 2023

@Gregory-Pereira: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test test

Use /test all to run all jobs.

In response to this:

/test tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gregory-Pereira
Copy link
Author

Unblocked, welcome to TP2 sprint lads!
ping @saber
ping @lance
needs a lgtm and approved label if we want to start testing containerization of these components

@cooktheryan
Copy link
Collaborator

lgtm

lance
lance reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments regarding comments ;) otherwise lgtm

cmd/tuf/server/main.go Outdated Show resolved Hide resolved
cmd/tuf/server/main.go Outdated Show resolved Hide resolved
@Gregory-Pereira Gregory-Pereira changed the base branch from redhat-v0.6.5 to redhat-v0.6 January 3, 2024 20:52
@Gregory-Pereira Gregory-Pereira force-pushed the midstream-enable-tuf-server-podman-deployment branch from a03eeb3 to fd3a5a0 Compare January 3, 2024 20:55
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gregory-Pereira, sabre1041

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gregory-Pereira Gregory-Pereira force-pushed the midstream-enable-tuf-server-podman-deployment branch from fd3a5a0 to 41e4cdf Compare January 3, 2024 20:56
@Gregory-Pereira Gregory-Pereira changed the base branch from redhat-v0.6 to main March 30, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance left review comments

@sabre1041 sabre1041 sabre1041 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Gregory-Pereira @openshift-merge-robot @cooktheryan @lance @sabre1041