Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): rm NODE_ENV var #45

Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix(build): rm NODE_ENV var #45

merged 1 commit into from
Mar 20, 2024

Conversation

kahboom
Copy link
Collaborator

@kahboom kahboom commented Mar 20, 2024

This PR removes NODE_ENV from being set from the Dockerfile, which is causing Konflux builds to fail because we are now referencing a dev dependency in next.config.js, which we don't get installed because NODE_ENV=production.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.96%. Comparing base (009afdf) to head (32869b9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   58.96%   58.96%           
=======================================
  Files          13       13           
  Lines        1511     1511           
  Branches       37       37           
=======================================
  Hits          891      891           
+ Misses        620      619    -1     
- Partials        0        1    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JasonPowr
Copy link

/lgtm thanks Rachel :)

@JasonPowr JasonPowr merged commit 7d10d46 into main Mar 20, 2024
16 checks passed
@JasonPowr JasonPowr deleted the dev branch March 20, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants