build(ci): disable next export, use build time vars for static build #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage 63.46% 63.46%
=======================================
Files 13 13
Lines 1511 1511
Branches 48 37 -11
=======================================
Hits 959 959
- Misses 551 552 +1
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
|
@kahboom any reason this is remaining unmerged? |
|
@lance tbh it just keeps getting put on the back burner but I'll rebase and get this one sorted asap |
kahboom
force-pushed
the
build-for-static-pages
branch
from
8a031cc
to
dc84a2e
Compare
Bundle ReportChanges will decrease total bundle size by 59.95MB ⬇️
|
kahboom
force-pushed
the
build-for-static-pages
branch
from
dc84a2e
to
3c8d04d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR should be tested against a running cluster to ensure there are no breaking changes due to the change in
next.config.jsexposing theNEXT_PUBLIC_REKOR_DEFAULT_DOMAINenv var at build time. Because these changes happen at build time, it should not have any effect, but is worth a double check. Unfortunately this needs to be done manually for now while e2e tests are still in development.To test:
NEXT_PUBLIC_REKOR_DEFAULT_DOMAINshould be set to the Rekor server automatically (whether you deploy by the Helm chart or the operator)