Skip to content

Commit

Permalink
minor changes
Browse files Browse the repository at this point in the history
  • Loading branch information
kahboom committed May 31, 2024
1 parent 4480ce1 commit f3a3fb9
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 10 deletions.
14 changes: 9 additions & 5 deletions .github/workflows/e2e-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,16 @@ name: Cross Browser End-to-End Testing (Cypress) 🚀
on:
push:
branches:
- '**'
- main
pull_request:
branches:
- '**'
types: [opened, reopened, synchronize]
types: [opened, synchronize, reopened]
schedule:
- cron: '0 2 * * FRI'

jobs:
cypress-run:
runs-on: ubuntu-latest
timeout-minutes: 60
timeout-minutes: 5

services:
docker:
Expand All @@ -28,6 +26,12 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2

- name: Login to Docker Hub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKER_HUB_USERNAME }}
password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}

- name: Create Docker secrets
run: |
echo ${{ secrets.CYPRESS_RECORD_KEY }} | docker secret create cypress_record_key -
Expand Down
9 changes: 4 additions & 5 deletions docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,11 @@ services:
depends_on:
- nextjs
secrets:
- source: CYPRESS_RECORD_KEY
- source: cypress_record_key
target: cypress_record_key
- source: GITHUB_TOKEN
- source: github_token
target: github_token
volumes:
# set mappings to access artifacts outside of containers
- ./artifacts/electron/videos:/e2e/cypress/videos
- ./artifacts/electron/screenshots:/e2e/cypress/screenshots
environment:
Expand All @@ -35,7 +34,7 @@ services:
command: npx cypress run

secrets:
CYPRESS_RECORD_KEY:
cypress_record_key:
external: true
GITHUB_TOKEN:
github_token:
external: true

0 comments on commit f3a3fb9

Please sign in to comment.