Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURESIGN-1285] Swithc to TA pipelines #175

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[SECURESIGN-1285] Swithc to TA pipelines #175

merged 1 commit into from
Aug 26, 2024

Conversation

bouskaJ
Copy link

@bouskaJ bouskaJ commented Aug 26, 2024

No description provided.

@bouskaJ bouskaJ marked this pull request as draft August 26, 2024 07:46
@bouskaJ bouskaJ force-pushed the ta_pipelines branch 3 times, most recently from 202a7fa to 26a55ee Compare August 26, 2024 07:58
@bouskaJ
Copy link
Author

bouskaJ commented Aug 26, 2024

@tommyd450 @JasonPowr PTAL. I updated both pipelines to use Trusted Artifacts SECURESIGN-1292 The on pull pipeline works (see https://console.redhat.com/application-pipeline/workspaces/rhtas/applications/fulcio/pipelineruns/fulcio-server-on-pull-request-jw58h) I am not sure how to test the on push pipeline.

The only failure is the fulcio-enterprise-contract but those failures are not caused by this PR.

@bouskaJ bouskaJ marked this pull request as ready for review August 26, 2024 08:23
JasonPowr
JasonPowr approved these changes Aug 26, 2024
View reviewed changes
Copy link

@JasonPowr JasonPowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bouskaJ Im not too familiar with this process, but based on this pr securesign/trillian#197, these changes lgtm :),

As for testing the on-push pipeline the only way to do that really is to merge this :)

@openshift-ci openshift-ci bot added the lgtm label Aug 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bouskaJ, JasonPowr

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bouskaJ bouskaJ merged commit f4363a9 into main Aug 26, 2024
18 of 22 checks passed
@bouskaJ
Copy link
Author

bouskaJ commented Aug 26, 2024

on-push pipeline works 🎉

@miyunari miyunari mentioned this pull request Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonPowr JasonPowr JasonPowr approved these changes

@tommyd450 tommyd450 Awaiting requested review from tommyd450

Assignees

@JasonPowr JasonPowr

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bouskaJ @JasonPowr