Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E automation support for XGBoost model #1288

Merged

Conversation

noopurintel
Copy link
Contributor

@noopurintel noopurintel commented Jan 20, 2025

We already have automation in place for bare metal and dockerized approaches using pytest framework for various models.
This PR aims to extend that support for XGBoost model as well.

Important: - Currently, it isn't possible to include XGBoost in the GitHub workflows as the regular GitHub runners can't support the huge data size required for this model.

Changes done:

  1. multiple files --> modified to include function call to setup data for the collaborators and handle the same during federation run.
  2. task_runner_dockerized_ws_e2e.yml --> removed 3.9 and added 3.12 python version.
  3. federated_runtime.yml --> removed author names, which was missed out in the previous PR.
  4. conftest.py --> added function calls to remove docker containers and networks, if any, in pytest_sessionfinish.

Successful runs:

  1. Task Runner E2E (bare metal) - https://github.com/noopurintel/openfl/actions/runs/12869907455
  2. Task Runner E2E (dockerized) - https://github.com/noopurintel/openfl/actions/runs/12870139066

@noopurintel noopurintel marked this pull request as ready for review January 20, 2025 14:40
@noopurintel noopurintel changed the title Draft: E2E automation for XGBoost model E2E automation support for XGBoost model Jan 20, 2025
tests/end_to_end/utils/federation_helper.py Fixed Show resolved Hide resolved
tests/end_to_end/utils/federation_helper.py Fixed Show resolved Hide resolved
@teoparvanov teoparvanov requested a review from kta-intel January 20, 2025 15:49
Copy link
Collaborator

@teoparvanov teoparvanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @noopurintel !

Copy link
Collaborator

@kta-intel kta-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanwarsh tanwarsh merged commit 4a1a135 into securefederatedai:develop Jan 22, 2025
22 checks passed
@noopurintel noopurintel deleted the noopur/xgb_higgs_automation branch January 23, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants