-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E automation support for XGBoost model #1288
Merged
tanwarsh
merged 19 commits into
securefederatedai:develop
from
noopurintel:noopur/xgb_higgs_automation
Jan 22, 2025
Merged
E2E automation support for XGBoost model #1288
tanwarsh
merged 19 commits into
securefederatedai:develop
from
noopurintel:noopur/xgb_higgs_automation
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
noopurintel
changed the title
Draft: E2E automation for XGBoost model
E2E automation support for XGBoost model
Jan 20, 2025
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
teoparvanov
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @noopurintel !
payalcha
reviewed
Jan 21, 2025
rahulga1
reviewed
Jan 21, 2025
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
Signed-off-by: noopur <[email protected]>
rahulga1
approved these changes
Jan 21, 2025
kta-intel
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have automation in place for bare metal and dockerized approaches using pytest framework for various models.
This PR aims to extend that support for XGBoost model as well.
Important: - Currently, it isn't possible to include XGBoost in the GitHub workflows as the regular GitHub runners can't support the huge data size required for this model.
Changes done:
task_runner_dockerized_ws_e2e.yml
--> removed 3.9 and added 3.12 python version.federated_runtime.yml
--> removed author names, which was missed out in the previous PR.conftest.py
--> added function calls to remove docker containers and networks, if any, in pytest_sessionfinish.Successful runs: