Fix LLVMTaintConfig struct-field tainting mapping all struct types#836
Open
fabianbs96 wants to merge 1 commit into
Open
Fix LLVMTaintConfig struct-field tainting mapping all struct types#836fabianbs96 wants to merge 1 commit into
fabianbs96 wants to merge 1 commit into
Conversation
) The StructConfigMap-building loop incorrectly mapped every identified LLVM struct type to the configured field name whenever any debug-info struct type matched the configured scope. This caused fields of unrelated struct types with the same name to be wrongly tainted. Fix: build the map by walking debug-declare records on allocas and correlating DICompositeType names with the alloca's allocated type, avoiding any dependency on LLVM IR type naming conventions. Performance: pre-build a StringMap (scope→name) so each alloca lookup is O(1) instead of O(|Variables|); replace double contains/at with a single find in the GEP check; add early-out when Config.Variables is empty. Boilerplate: extract forEachDbgDeclare and stripTypedefsToStruct into LLVMIRToSrc (LLVM-version-specific includes confined to the .cpp; header uses llvm::function_ref for a stable interface). Regression test: DataMember_02_Json verifies that X::A GEPs are sources while Y::A GEPs are not when only X is configured. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #835