Skip to content

drift: Record review of TesseraCT's graceful shutdown change - #71

Merged
robstradling merged 1 commit into
mainfrom
review-tesseract-shutdown
Nov 16, 2026
Merged

robstradling merged 1 commit into
mainfrom
review-tesseract-shutdown

Conversation

@robstradling

Copy link
Copy Markdown
Member

What

Records the review of transparency-dev/tesseract@36e50a1 ("Drain the log and stop background tasks on shutdown (#991)") in test/differential/upstream.json. That commit is why the Watched upstream files drift check fails.

Why no other changes are needed

The commit makes TesseraCT finish in-flight requests and integrate accepted entries before it stops:

  • ctlog.go: NewLogHandler returns a *LogHandler wrapping the same handler, and adds Shutdown/GracefulShutdown;
  • the storage plumbing and cmd/tesseract/*/main.go call it when the server stops.

It doesn't change the routes, the MaxCertChainBytes body limit, request parsing or chain validation (chain_validation.go, lax509 and x509util are untouched). So neither the snippet nor the origin models need to change. The drift workflow's differential tests against the latest parsers also passed.

--update also advanced certificate-transparency-go's reviewed to the current master (f555d4f). None of its watched files changed. Sunlight is unchanged.

Testing

node test/differential/upstream.mjs now reports no changes since review.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

TesseraCT's 36e50a1 ("Drain the log and stop background tasks on shutdown")
changes ctlog.go so that the log is drained when the server is stopped. It
doesn't change the routes, the body size limit, request parsing or chain
validation, so neither the snippet nor the origin models need to change.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@robstradling
robstradling merged commit b0ab5a8 into main Nov 16, 2026
21 checks passed
@robstradling
robstradling deleted the review-tesseract-shutdown branch November 16, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant