Repository navigation
drift: Record review of TesseraCT's graceful shutdown change - #71
Merged
Merged
Conversation
TesseraCT's 36e50a1 ("Drain the log and stop background tasks on shutdown")
changes ctlog.go so that the log is drained when the server is stopped. It
doesn't change the routes, the body size limit, request parsing or chain
validation, so neither the snippet nor the origin models need to change.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Records the review of transparency-dev/tesseract@36e50a1 ("Drain the log and stop background tasks on shutdown (#991)") in
test/differential/upstream.json. That commit is why the Watched upstream files drift check fails.Why no other changes are needed
The commit makes TesseraCT finish in-flight requests and integrate accepted entries before it stops:
ctlog.go:NewLogHandlerreturns a*LogHandlerwrapping the same handler, and addsShutdown/GracefulShutdown;cmd/tesseract/*/main.gocall it when the server stops.It doesn't change the routes, the
MaxCertChainBytesbody limit, request parsing or chain validation (chain_validation.go,lax509andx509utilare untouched). So neither the snippet nor the origin models need to change. The drift workflow's differential tests against the latest parsers also passed.--updatealso advanced certificate-transparency-go'sreviewedto the currentmaster(f555d4f). None of its watched files changed. Sunlight is unchanged.Testing
node test/differential/upstream.mjsnow reports no changes since review.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com