Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FastUpdateModel docstrings #627

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

st--
Copy link
Member

@st-- st-- commented Sep 20, 2022

The docstrings of the FastUpdateModel abstract methods seemed to be in error; I believe this is what is meant, but please double-check.

The docstrings of the FastUpdateModel abstract methods seemed to be in error; I believe this is what is meant, but please double-check.
@@ -224,7 +224,7 @@ def conditional_predict_joint(
:param additional_data: Dataset with query_points with shape [..., N, D] and observations
with shape [..., N, L]
:return: The mean and covariance of the joint marginal distribution at each batch of points
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what is the "joint marginal distribution"? is this the joint distribution over all fs? So should this be

Suggested change
:return: The mean and covariance of the joint marginal distribution at each batch of points
:return: The mean and covariance of the joint distribution at each batch of points

?

@hstojic
Copy link
Collaborator

hstojic commented Sep 20, 2022

good to hear from you @st-- !
@vpicheny is the main author of this code (though @uri-granta chipped in as well I think), Victor care to check this out?

@uri-granta uri-granta requested a review from vpicheny October 31, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants