Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QUIC transport parameters as a TLS extension #4614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kayoch1n
Copy link

@kayoch1n kayoch1n commented Dec 17, 2024

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

This PR is NOT an implementation of QUIC. Instead, it adds the QUIC transport parameters as a TLS exntension, which has an extension type of 57(0x39)

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.73%. Comparing base (a8583a5) to head (0f3622d).

Files with missing lines Patch % Lines
scapy/layers/tls/quic.py 94.82% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4614      +/-   ##
==========================================
- Coverage   81.38%   78.73%   -2.66%     
==========================================
  Files         359      335      -24     
  Lines       86029    80950    -5079     
==========================================
- Hits        70017    63735    -6282     
- Misses      16012    17215    +1203     
Files with missing lines Coverage Δ
scapy/layers/tls/extensions.py 84.04% <100.00%> (+0.14%) ⬆️
scapy/layers/tls/quic.py 94.82% <94.82%> (ø)

... and 285 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant