Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for websockets #4579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lucasdrufva
Copy link

@lucasdrufva lucasdrufva commented Nov 3, 2024

Adds support for websockets.

HTTP dissector has been updated to support omitting the reason phrase as this is usually done when upgrading to websocket connection.

fixes #4578

@gpotter2
Copy link
Member

gpotter2 commented Nov 3, 2024

Hi ! This looks pretty cool !

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 98.07692% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.74%. Comparing base (8e08cbf) to head (60a13b7).

Files with missing lines Patch % Lines
scapy/contrib/websocket.py 97.97% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4579      +/-   ##
==========================================
- Coverage   81.62%   78.74%   -2.89%     
==========================================
  Files         358      334      -24     
  Lines       85652    80602    -5050     
==========================================
- Hits        69915    63470    -6445     
- Misses      15737    17132    +1395     
Files with missing lines Coverage Δ
scapy/layers/http.py 80.54% <100.00%> (-1.90%) ⬇️
scapy/contrib/websocket.py 97.97% <97.97%> (ø)

... and 284 files with indirect coverage changes

@lucasdrufva lucasdrufva marked this pull request as ready for review November 8, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websocket support
2 participants