Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payload_len calculation for DataPacket. #4545

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Splinter1984
Copy link

@Splinter1984 Splinter1984 commented Oct 1, 2024

This PR fix pl_len calculation issue for DataPacket of RTPS protocol.
Take into account the size of inlineQoS during payload length calculation.
Closes #4594

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.71%. Comparing base (6f0faf3) to head (06aeab2).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4545      +/-   ##
==========================================
- Coverage   81.61%   78.71%   -2.91%     
==========================================
  Files         356      331      -25     
  Lines       85545    80350    -5195     
==========================================
- Hits        69819    63246    -6573     
- Misses      15726    17104    +1378     
Files with missing lines Coverage Δ
scapy/contrib/rtps/common_types.py 95.27% <100.00%> (ø)

... and 282 files with indirect coverage changes

@Splinter1984 Splinter1984 force-pushed the fix_data_packet_pl_len branch from c0193ed to d87ccc8 Compare October 4, 2024 14:54
Take into account size of `inlineQoS`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTPS DataPacketField wrong payload len.
1 participant