WIP ICMP Extension Header bugfixes #4451
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing my work with ICMP Extension Header started with this issue GH-4281, I noticed that there are more bugs or missing mechanisms (like GH-4353).
I don't have enough time to do all things at once, also it would be nice to discuss some details during implementation to fulfill your expectations and met coding style.
I started with IPv4 variant, in incoming future it would be necessary to implement similar changes for IPv6.
At this moment I fixed:
length
attribute when extension header is present and field is not set.To be done:
length
field.RFC for reference - RFC 4884: Extended ICMP to Support Multi-Part Messages.