Pass the fd to the underlying NativeCANSocket #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4158 +/- ##
==========================================
- Coverage 81.78% 81.78% -0.01%
==========================================
Files 330 330
Lines 76331 76340 +9
==========================================
+ Hits 62431 62434 +3
- Misses 13900 13906 +6
|
devrim-ayyildiz
changed the title
polybassa
reviewed
Oct 25, 2023
devrim-ayyildiz
force-pushed
the
isotp-canfd
branch
from
2ea1eb0 to
36df287
Compare
polybassa
reviewed
Oct 27, 2023
devrim-ayyildiz
force-pushed
the
isotp-canfd
branch
from
36df287 to
b276e89
Compare
|
one last thing... now you need to add the tag: |
ISOTPSoftSocket should pass the fd (CanFD support) to the NativeCANSocket instance it creates. Otherwise it will always be created as non CanFD.
devrim-ayyildiz
force-pushed
the
isotp-canfd
branch
from
b276e89 to
afe82ef
Compare
polybassa
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISOTPSoftSocket should pass the fd (CanFD support) to the NativeCANSocket instance it creates. Otherwise it will always be created as non CanFD.