Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent sendpfast API (breaking) #4157

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Oct 23, 2023

  • improve consistency in APIs

The behavior of:

sendpfast(Ether(), loop=1)

is now equivalent to:

sendp(Ether(), loop=1)

where previously it would have been:

sendp(Ether(), loop=0)

Calling @p-l- for review

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #4157 (2130ee3) into master (4fefbb0) will increase coverage by 0.02%.
Report is 3 commits behind head on master.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #4157      +/-   ##
==========================================
+ Coverage   81.76%   81.78%   +0.02%     
==========================================
  Files         330      330              
  Lines       76315    76334      +19     
==========================================
+ Hits        62399    62431      +32     
+ Misses      13916    13903      -13     
Files Coverage Δ
scapy/supersocket.py 75.66% <100.00%> (ø)
scapy/sendrecv.py 87.97% <50.00%> (-0.25%) ⬇️

... and 15 files with indirect coverage changes

scapy/sendrecv.py Outdated Show resolved Hide resolved
@p-l- p-l- merged commit 363d376 into secdev:master Oct 27, 2023
@gpotter2 gpotter2 deleted the sendpfastapi branch October 27, 2023 16:16
ntheule pushed a commit to ntheule/edit-intro-doc that referenced this pull request Oct 28, 2023
@gpotter2 gpotter2 added this to the 2.6.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants