Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stupid OSes #4155

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Support stupid OSes #4155

merged 1 commit into from
Oct 23, 2023

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Oct 22, 2023

  • restore support for OSes that do not support IPv6
  • move banner generation into its own function (main.py), and add mini argument

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #4155 (db58c41) into master (4fefbb0) will increase coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #4155      +/-   ##
==========================================
+ Coverage   81.76%   81.77%   +0.01%     
==========================================
  Files         330      330              
  Lines       76315    76328      +13     
==========================================
+ Hits        62399    62421      +22     
+ Misses      13916    13907       -9     
Files Coverage Δ
scapy/layers/dns.py 86.89% <100.00%> (+0.06%) ⬆️
scapy/layers/hsrp.py 90.00% <100.00%> (+0.71%) ⬆️
scapy/layers/ntp.py 85.32% <ø> (-0.04%) ⬇️
scapy/utils.py 78.66% <100.00%> (+0.75%) ⬆️
scapy/config.py 83.02% <0.00%> (ø)
scapy/pton_ntop.py 86.84% <50.00%> (-2.05%) ⬇️
scapy/main.py 71.91% <77.77%> (+0.09%) ⬆️

... and 6 files with indirect coverage changes

guedou
guedou previously approved these changes Oct 22, 2023
Copy link
Member

@guedou guedou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these OSes?

@gpotter2
Copy link
Member Author

gpotter2 commented Oct 22, 2023

What are these OSes?

Only the most ridiculous ones: https://gpotter2.github.io/secdev.github.io/?try=1

@gpotter2 gpotter2 merged commit d54a457 into secdev:master Oct 23, 2023
@gpotter2 gpotter2 deleted the stupid-oses branch October 23, 2023 21:22
@gpotter2 gpotter2 added this to the 2.6.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants