Improve parsing of UDS DTC Snapshots and ExtendedData #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4149 +/- ##
==========================================
- Coverage 81.77% 78.40% -3.37%
==========================================
Files 330 330
Lines 76290 76310 +20
==========================================
- Hits 62383 59832 -2551
- Misses 13907 16478 +2571
|
|
It's a bad practice to start PRs with no description. Generally when I see stuff like that I think that it's a draft. |
Sorry |
guedou
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the definition of DTCs inside the UDS_RDTCI packet to have a better representation of the DTC. Additionally, a DTC Snapshot Packet class is introduced to allow customization of DTC Snapshot records for individual ECUs