Adds theme support to code coverage.#5833
Closed
gammamatrix wants to merge 3 commits intosebastianbergmann:mainfrom
Closed
Adds theme support to code coverage.#5833gammamatrix wants to merge 3 commits intosebastianbergmann:mainfrom
gammamatrix wants to merge 3 commits intosebastianbergmann:mainfrom
Conversation
…or the upgrade to Bootstrap 5.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5833 +/- ##
============================================
- Coverage 91.87% 91.86% -0.02%
+ Complexity 6568 6567 -1
============================================
Files 700 698 -2
Lines 19848 19851 +3
============================================
Hits 18236 18236
- Misses 1612 1615 +3 ☔ View full report in Codecov by Sentry. |
…tstrap-5-add-theme
Author
|
Now that GH-1037 was merged, I will update this branch. I will need to read up what changed to cause conflicts. |
da21665 to
4dddc8c
Compare
1bb9097 to
5af6639
Compare
Owner
|
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements and Specifications
php-code-coverage currently uses Bootstrap 4 to render HTML code coverage reports.
Bootstrap 5 introduces CSS Variables and adds Color Modes for Themes.
Bootstrap sets the color mode (theme) in the top level html tag.
wheatis an example forcustomCssFileand does not come with Bootstrap 5.Changes
Requires: sebastianbergmann/php-code-coverage#1036
phpunit.xsdProposed changes:
phpunit.xsdschema.Default Color Modes
Bootstrap 5 comes with two color modes (themes),
darkand the default:light.Theme: `default` (light)
Theme: `dark`
Theme: `dark` - with color override options from phpunit.xml
Theme: `light` - with color override options from phpunit.xml
Custom Theme: `wheat` - with color override options from phpunit.xml
Multiple themes may be put in the
customCssFileoption.Here is an example custom theme called
wheat.Dev Notes