Project: Make parent::__construct() call explicit#1112
Merged
sebastianbergmann merged 2 commits intosebastianbergmann:mainfrom Nov 20, 2025
Merged
Project: Make parent::__construct() call explicit#1112sebastianbergmann merged 2 commits intosebastianbergmann:mainfrom
sebastianbergmann merged 2 commits intosebastianbergmann:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
============================================
- Coverage 88.82% 88.82% -0.01%
+ Complexity 1391 1390 -1
============================================
Files 98 98
Lines 4655 4653 -2
============================================
- Hits 4135 4133 -2
Misses 520 520 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
staabm
commented
Nov 20, 2025
| $dom = new DOMDocument; | ||
| $dom->loadXML('<?xml version="1.0" ?><phpunit xmlns="https://schema.phpunit.de/coverage/1.0"><build/><project/></phpunit>'); | ||
|
|
||
| $this->setContextNode( |
Contributor
Author
There was a problem hiding this comment.
this call was equivalent to the baseclass __construct() implementation.. but we shouldn't rely on implementation knowledge across classes, when not necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.