Fix Flog#flog and FlogCLI::run to use path expansion the same way.#65
Open
daveinman wants to merge 5 commits intoseattlerb:masterfrom
Open
Fix Flog#flog and FlogCLI::run to use path expansion the same way.#65daveinman wants to merge 5 commits intoseattlerb:masterfrom
daveinman wants to merge 5 commits intoseattlerb:masterfrom
Conversation
added 5 commits
April 23, 2019 16:47
…in Flog#flog and FlogCLI shares it a test was added to verify the new code.
… This means both Flog and FlogCli share this same behavior. Failing to supply a ruby source file or finding no source file readable are now two different aborts. Usage statement is updated to show the use of standard input ruby source. Using require_relative to make sure ruby source file is loaded from development directory rather than an installed gem.
…log to expand dirs in its args to files. It also returns false if no file or standard input is processed and true otherwise.
…e to insure files are found from the developers dir rather than an installed gem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other tools using Flog#flog() can benefit from path expansion that only worked in FlogCLI::run. The changes I made have them both use the same system for path expansion. Previously, one could not differentiate whether an abort occurred for:
* no input files
* no readable input file
An update to the usage message of flog was made to indicate a dash may be used as an argument to indicate stdin is to be read for ruby code.
A unit test was created to test the new functionality.
Also, small changes were made to make sure developer's running unit tests would not inadvertently get this packages installed ruby gem code during 'requires'.