add tcb_unbind_notification invocation #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why this failed the build check. I don't see anything of note in the log and it works locally. |
|
Thanks for this! I've seen spurious errors like this before where the logs aren't available. Not sure what happened, but I just re-ran the job and it passed. Would you mind turning this PR into one linear commit? At least for now, we are trying to maintain a linear commit history. |
alwin-joshy
force-pushed
the
tcb_unbind_ntfn
branch
from
3589567
to
dda5f14
Compare
Signed-off-by: Alwin Joshy <[email protected]>
alwin-joshy
force-pushed
the
tcb_unbind_ntfn
branch
from
dda5f14
to
25d029a
Compare
|
Done, sorry. Accidentally synced with main using merge instead of rebase |
|
That CI failure where the logs disappear happened again. Weird. I’ll investigate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.