Replace deprecated function calls and parameters #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit works towards se-sic#260. Signed-off-by: Thomas Bock <[email protected]>
As of `ggplot2` version 3.5.0, the function `discrete_scale`, which is used for `plot.network` in coronet, does not require a `scale_name` parameter anymore. Even more, this parameter has been deprecated. Therefore, we also don't use it any more in coronet. However, as a consequence of this, the plotting module of coronet requires `ggplot2` version 3.5.0 or higher, as of now. Signed-off-by: Thomas Bock <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #279 +/- ##
==========================================
+ Coverage 81.67% 81.69% +0.01%
==========================================
Files 16 16
Lines 5147 5146 -1
==========================================
Hits 4204 4204
+ Misses 943 942 -1 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
showcase.Rwith respect to my changes.dev.Description
Replace deprecated igraph functions in 'util-networks-metrics.R' and remove deprecated
scale_nameparameter from plotting module. This works towards #260.Changelog
erdos.renyi.gameof type "gnm" has been replaced bysample_gnmaverage.path.lengthhas been replaced bymean_distancegraph.densityhas been replaced byedge_densityis.simplehas been replaced byis_simpleggplot2version 3.5.0, the functiondiscrete_scale, which is used forplot.networkin coronet, does not require ascale_nameparameter anymore. Even more, this parameter has been deprecated. Therefore, we also don't use it any more in coronet. However, as a consequence of this, the plotting module of coronet requiresggplot2version 3.5.0 or higher, as of now.