-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous improvements regarding network splitting and simplification #268
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #268 +/- ##
==========================================
+ Coverage 80.89% 80.92% +0.02%
==========================================
Files 16 16
Lines 5036 5043 +7
==========================================
+ Hits 4074 4081 +7
Misses 962 962 ☔ View full report in Codecov by Sentry. |
Works towards se-sic#260. Signed-off-by: Maximilian Löffler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This PR looks good to me. I just have a few comments regarding documentation and tests.
This change is in-line with the current treatment of the elements that occur after the last bin. Further, this fixes a minor "bug" where bin indecees are used to determine bin labels by indexing into a list of labels. Elements before the first bin received bin index 0, however, R is 1-indexed. Note: This "bug" did not cause problems because the bin with the incorrect label will be ignored later anyways. Works towards se-sic#267. Signed-off-by: Maximilian Löffler <[email protected]>
Add a function that takes a network as input and simply removes all edges that are exact duplicates of each other. Works towards se-sic#138. Signed-off-by: Maximilian Löffler <[email protected]>
Works towards se-sic#138. Signed-off-by: Maximilian Löffler <[email protected]>
Works towards se-sic#265. Signed-off-by: Maximilian Löffler <[email protected]>
Works towards se-sic#265. Signed-off-by: Maximilian Löffler <[email protected]>
Signed-off-by: Maximilian Löffler <[email protected]>
Signed-off-by: Maximilian Löffler <[email protected]>
Just one final question before I can approve this PR: The splitting fix regarding the elements before the first bin does not have any user-visible effects? If this really is the case, I am fine with not mentioning it. If it can have user-visible effects, we should mention it in the NEWS.md. |
Yup, it has no user-visible effect. That is why I found it hard to justify mentioning it in the NEWS and decided against it 😄 |
Prerequisites
showcase.R
with respect to my changes.dev
.Description
This PR Includes somewhat minor fixes for multiple open issues.
Changelog
igraph::is.loop
byigraph::which_loop
andigraph::list.graph.attributes
byigraph::graph_attr_names
cumulative
parameter to theconstruct.ranges
function which allows to create cumulative ranges from the given revisions