Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis fixes #183

Merged
merged 4 commits into from
Nov 15, 2020
Merged

Travis fixes #183

merged 4 commits into from
Nov 15, 2020

Conversation

bockthom
Copy link
Collaborator

@bockthom bockthom commented Nov 8, 2020 •
edited
Loading

Prerequisites

  • I adhere to the coding conventions (described here) in my code.
  • I have updated the copyright headers of the files I have modified.
  • I have written appropriate commit messages, i.e., I have recorded the goal, the need, the needed changes, and the location of my code modifications for each commit. This includes also, e.g., referencing to relevant issues.
  • I have put signed-off tags in all commits.
  • I have updated the changelog file NEWS.md appropriately.
  • The pull request is opened against the branch dev.

Description

Adjust package installation script to fix Travis CI builds:

Travis builds currently fail (for a few weeks) due to two different reasons:

On the one hand, the log output exceeds the maximum log length of travis,
resulting in failing builds. This is prevented by setting the parameters
`verbose` and `quiet` to `TRUE`, as then the package compilation log is
not printed to the log but the result of package installation is clearly
perceptible in the log.

On the other hand, travis installs lots of packages which are not necessary
as they are just suggestions of other packages but not necessary dependencies.
Installing such unnecessary packages my lead to problems. This is
circumvented by setting the `dependencies` parameter to `NA` as this results
in installing only necessary dependencies and imports, whereas the former
`TRUE` value of this parameter also led to installing suggested but
unnecessary packages.

Those two fixes make the Travis CI builds successful again.

Props to @clhunsen for experimenting with the parameters and proposing
the first part of this commit regarding the `verbose` and `quiet`
parameters of the `install.packages` function.

In addition, add R version 4.0 to the test suite.

Changelog

@bockthom
Adjust package installation script to fix travis builds
1ba0367 
Travis builds currently fail (for a few weeks) due to two different reasons:

On the one hand, the log output exceeds the maximum log length of travis,
resulting in failing builds. This is prevented by setting the parameters
`verbose` and `quiet` to `TRUE`, as then the package compilation log is
not printed to the log but the result of package installation is clearly
perceptible in the log.

On the other hand, travis installs lots of packages which are not necessary
as they are just suggestions of other packages but not necessary dependencies.
Installing such unnecessary packages my lead to problems. This is
circumvented by setting the `dependencies` parameter to `NA` as this results
in installing only necessary dependencies and imports, whereas the former
`TRUE` value of this parameter also led to installing suggested but
unnecessary packages.

Those two fixes hopefully makes travis builds successful again.

Props to @clhunsen for experimenting with the parameters and proposing
the first part of this commit regarding the `verbose` and `quiet`
parameters of the `install.packages` function.

This commit addresses parts of se-sic#161.

Signed-off-by: Thomas Bock <[email protected]>
@bockthom
Add R version 4.0 to test suite
40aa0d8 
This is related to issue se-sic#161.

Signed-off-by: Thomas Bock <[email protected]>
@bockthom bockthom added this to the v3.7 milestone Nov 8, 2020
@bockthom bockthom requested a review from clhunsen November 8, 2020 23:35
@bockthom bockthom mentioned this pull request Nov 8, 2020
Open
@bockthom
Adjust recommended R version in README
92be262 
As R version 3.3.1 is quite outdated, update the corresponding statement in our README and recommend R version 3.6.3.

Signed-off-by: Thomas Bock <[email protected]>
@bockthom
Update changelog
df367d2 
Signed-off-by: Thomas Bock <[email protected]>
@bockthom bockthom mentioned this pull request Nov 11, 2020
Merged
6 tasks
clhunsen
clhunsen approved these changes Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@clhunsen clhunsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your fixes, @bockthom! Everything looks nice and feels cozy. 😀 👍

@hechtlC, you can merge if you agree. 🙂

hechtlC
hechtlC approved these changes Nov 15, 2020
View reviewed changes
Copy link
Contributor

@hechtlC hechtlC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work thanks @bockthom .
I will merge this now.

@hechtlC hechtlC merged commit bd1ab32 into se-sic:dev Nov 15, 2020
@bockthom bockthom deleted the travis-fixes branch November 16, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clhunsen clhunsen clhunsen approved these changes

@hechtlC hechtlC hechtlC approved these changes

Assignees

@clhunsen clhunsen

Labels
None yet
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.
3 participants
@bockthom @clhunsen @hechtlC