Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable demos are using the new metadata #2175

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

lajohn4747
Copy link
Contributor

resolves #2131
CU-86b19awwy

download_demo should now download the json and store into Metadata object. New metadata is downloaded as metadata_v2.json but kept a check path metadata_v1.json just in case I missed any zip files.

@sdv-team
Copy link
Contributor

sdv-team commented Aug 7, 2024

@lajohn4747 lajohn4747 marked this pull request as ready for review August 7, 2024 17:16
@lajohn4747 lajohn4747 requested a review from a team as a code owner August 7, 2024 17:16
sdv/data_processing/data_processor.py Outdated Show resolved Hide resolved
sdv/datasets/demo.py Show resolved Hide resolved
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sdv/datasets/demo.py Show resolved Hide resolved
sdv/utils/utils.py Show resolved Hide resolved
@lajohn4747 lajohn4747 merged commit c212c08 into feature/metadata Aug 13, 2024
39 checks passed
@lajohn4747 lajohn4747 deleted the issue_2131_metadata_for_demos branch August 13, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants