-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable demos are using the new metadata #2175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontanez24
reviewed
Aug 7, 2024
amontanez24
reviewed
Aug 8, 2024
amontanez24
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
pvk-developer
approved these changes
Aug 12, 2024
R-Palazzo
pushed a commit
that referenced
this pull request
Sep 19, 2024
R-Palazzo
pushed a commit
that referenced
this pull request
Sep 24, 2024
R-Palazzo
pushed a commit
that referenced
this pull request
Sep 26, 2024
R-Palazzo
pushed a commit
that referenced
this pull request
Sep 26, 2024
amontanez24
pushed a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2131
CU-86b19awwy
download_demo
should now download the json and store intoMetadata
object. New metadata is downloaded asmetadata_v2.json
but kept a check pathmetadata_v1.json
just in case I missed any zip files.