Ensure that primary and sequence keys cannot be the same #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontanez24
approved these changes
Jul 3, 2024
amontanez24
reviewed
Jul 4, 2024
sdv/metadata/single_table.py
Outdated
| setting_primary_as_sequence = key_type == 'sequence' and column_name == self.primary_key | ||
| if setting_sequence_as_primary or setting_primary_as_sequence: | ||
| raise InvalidMetadataError( | ||
| f'The column ({column_name}) cannot be set as {key_type}_key as it is already set as the ' |
There was a problem hiding this comment.
This line is 111 characters. Not sure why the linter isn't complaining
There was a problem hiding this comment.
@gsheni It seems to be because we are ignoring the line-to-long rule here
Line 206 in f55e51e
There was a problem hiding this comment.
Added that rule back in and fixed the line length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2096
CU-86b11yb3u
Make sure
_validate_keypreventsprimary_keyfrom being the same assequence_key