Add database_role option to scope checks for replicas
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffharcourt
force-pushed
the
gh-using-follower
branch
2 times, most recently
from
53f6031
to
fb02238
Compare
It can be useful to confirm that certain database queries are being made against a primary database or a replica database. This change adds a new option `database_role`, which makes the query counter only count queries that were made against a database with the specified role. We've used this logic at CommonLit for several years to ensure we're querying the right database. This works in test environments even if your primary and replica database configurations point at the same database.
geoffharcourt
force-pushed
the
gh-using-follower
branch
from
fb02238
to
3e21609
Compare
|
@sds thanks for the review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful to confirm that certain database queries are being
made against a primary database or a replica database. This change
adds a new option
database_role, which makes the query counter onlycount queries that were made against a database with the specified
role.
We've used this logic at CommonLit for several years to ensure we're
querying the right database. This works in test environments even if
your primary and replica database configurations point at the same
database.
This is a retry at the work in #51. CI is failing on Rails Edge, but
it doesn't look related to the changes as far as I can tell.