-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Rails 7.1.x #56
Conversation
uh oh, are you still running builds on travis? That isn't going to work I think, travis doesn't really give free resources to open source anymore. I don't understand the current code conflict, how I can't seem to rebase on current main. Trying to work it out. |
ca1bc67
to
e7171fc
Compare
e7171fc
to
d4300bb
Compare
I have run tests manually locally on Rails 7.1.0
|
Oh hey, Github Actions CI is running, ok, I'll try to add a Rails 7.1 to build! |
Appraisals were testing with sqlite3 |
OK, I notice this is still only testing with ruby 3.0. I can add in ruby 3.1 and 3.2. I think it makes sense to switch the CI matrix to be include-only. I can do all that in a separate PR once this is approved/merged. |
@sds as a previous committer to this repo - could you take a look at this PR and merge/release if happy? Thanks! |
@trotzig If you still have commit rights...? |
bump |
@sds or anyone else, is this gem still maintained? Any chance of a merge and release? Should we consider forking to get a release that works with Rails 7.1? |
@sds do say if you have anything that you'd like to change about this before a merge! 🙇 |
@sds @rafaelsales Do you have any guidance on the future of this project? This issue is currently blocking our upgrade to Rails 7.1 |
Looks like all tests pass as-is, just needed to allow Rails 7.1 in gemspec.
Closes #55