Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Rails 7.1.x #56

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Allow Rails 7.1.x #56

merged 2 commits into from
Dec 13, 2023

Conversation

jrochkind
Copy link
Contributor

@jrochkind jrochkind commented Oct 5, 2023

Looks like all tests pass as-is, just needed to allow Rails 7.1 in gemspec.

Closes #55

@jrochkind
Copy link
Contributor Author

jrochkind commented Oct 5, 2023

uh oh, are you still running builds on travis? That isn't going to work I think, travis doesn't really give free resources to open source anymore.

I don't understand the current code conflict, how I can't seem to rebase on current main. Trying to work it out.

@jrochkind jrochkind force-pushed the allow_rails_7.1 branch 2 times, most recently from ca1bc67 to e7171fc Compare October 5, 2023 16:29
@jrochkind
Copy link
Contributor Author

I have run tests manually locally on Rails 7.1.0

jrochkind-shi db-query-matchers (allow_rails_7.1) $ bundle show activesupport
/Users/jrochkind/.gem/ruby/3.2.2/gems/activesupport-7.1.0

jrochkind-shi db-query-matchers (allow_rails_7.1) $ bundle show activerecord
/Users/jrochkind/.gem/ruby/3.2.2/gems/activerecord-7.1.0

jrochkind-shi db-query-matchers (allow_rails_7.1) $ bundle exec rspec
...................................................................

Finished in 0.04188 seconds (files took 0.60796 seconds to load)
67 examples, 0 failures


jrochkind-shi db-query-matchers (allow_rails_7.1) $

@jrochkind
Copy link
Contributor Author

Oh hey, Github Actions CI is running, ok, I'll try to add a Rails 7.1 to build!

@jrochkind
Copy link
Contributor Author

Appraisals were testing with sqlite3 "~> 1.4", which is 1.4.x only, when sqlite3 1.6 is out. I don't think you meant to lock to 1.4.x; will open it up at least for latest Rails.

@jrochkind
Copy link
Contributor Author

OK, I notice this is still only testing with ruby 3.0.

I can add in ruby 3.1 and 3.2. I think it makes sense to switch the CI matrix to be include-only. I can do all that in a separate PR once this is approved/merged.

@owst
Copy link

owst commented Oct 31, 2023

@sds as a previous committer to this repo - could you take a look at this PR and merge/release if happy? Thanks!

@hlascelles
Copy link

@trotzig If you still have commit rights...?

@ckhall
Copy link

ckhall commented Nov 17, 2023

bump

@jrochkind jrochkind mentioned this pull request Nov 21, 2023
@jrochkind
Copy link
Contributor Author

@sds or anyone else, is this gem still maintained? Any chance of a merge and release? Should we consider forking to get a release that works with Rails 7.1?

@hlascelles
Copy link

@sds do say if you have anything that you'd like to change about this before a merge! 🙇

@scottwhudson
Copy link

@sds @rafaelsales Do you have any guidance on the future of this project? This issue is currently blocking our upgrade to Rails 7.1

@sds sds merged commit 5fa15be into sds:main Dec 13, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Rails 7.1
6 participants