Improve HID driver support for hasseb #146
Conversation
Functioning examples for flash and tc
| @@ -714,40 +723,72 @@ def __init__(self, *args, **kwargs): | |||
| self._response_available = asyncio.Event() | |||
| self._response = None | |||
|
|
|||
| def _initialise_device(self): | |||
There was a problem hiding this comment.
when is this method called ?
There was a problem hiding this comment.
Line 143 self._initialise_device(), it overrides hid class method.
There was a problem hiding this comment.
please make a call to super()._initialise_device() and don't forget to set connected
| byte_a, byte_b = frame | ||
| data = struct.pack('BBBBBBBBBB', 0xAA, self._HASSEB_DALI_FRAME, self._sn, | ||
| frame_length, expect_reply, | ||
| transmitter_settling_time, send_twice, |
There was a problem hiding this comment.
how is send_twice actually sent twice !?
There was a problem hiding this comment.
It needs further testing to confirm, however in my testing the device sends it when send_twice is set > 0. value of send twice is used as delay in ms between the two sends.
There was a problem hiding this comment.
you are creating a single packet, with a format which I haven't seen documented, can you link where you saw this struct ?
Rewrote the send and receive functions for hasseb in hid.py
Added support for firmware version reading for hasseb in hid.py
Updated examples for flash and tc for hasseb tested on actual hardware