Complete interactive programming #3

vivienyuwenchen · 2017-10-30T02:59:41Z

No description provided.

…veProgramming

SeunginLyu · 2017-12-03T19:44:47Z

Game4.py

@@ -0,0 +1,165 @@
+import os, sys


Please add a few lines of comments explaining what this cool game is about!

SeunginLyu · 2017-12-03T19:51:34Z

Game4.py

+        """Main screen for game."""
+        # initialize player
+        count = 0
+        play_len = 25


It might be easier to follow the code if all the constants (or config variables) are all in one file. You can make a config.py class and put all the constants there, and load all the config variables at once when initializing the game. Also, it's a convention to use capital letters for constants e.g) PLAY_LEN = 25

This convention (and others) come from https://www.python.org/dev/peps/pep-0008/#constants

SeunginLyu · 2017-12-03T19:55:36Z

Game4.py

+        obstacles = []
+        new_obstical = False
+        # uncomment and place line below in [] of obstacles = [] to generate random obstacles:
+        # Obstacle(obs_x, obs_y, obs_len, self.screen,'BLUE')


Could you let user change these settings without interacting with the code? (uncommenting and stuff)

SeunginLyu · 2017-12-03T19:56:49Z

Game4.py

+        obs_dt = 500
+
+        # main event loop
+        while 1:


while 1 does not provide any direct information about when the loop is supposed to end. Using a boolean variable named running = true provides better documentation in this case.

Yes, prefer True or False for a boolean.

Going beyond: you can also use itertools to produce a continuously increasing set of integers, like range(1, 100) except it keeps going forever instead of stopping at 100:

for count in itertools.count(1):

SeunginLyu · 2017-12-03T20:08:23Z

misc.py

@@ -0,0 +1,128 @@
+import os, sys


I think this file can be named models.py. The current file name misc.py does not really provide helpful documentation.

SeunginLyu · 2017-12-03T20:09:06Z

pygame_base_template.py

+    for event in pygame.event.get():
+        if event.type == pygame.QUIT:
+            done = True
+        #if event.type == pygame.KEYDOWN:


Please remove comments when submitting the final code

Check. “comments” == “commented-out code”, in this context.

SeunginLyu · 2017-12-03T20:09:24Z

pygame_base_template.py

+
+    jumpover = False
+
+    #if False:#if detect_key_press() == 'space':


please remove comments

SeunginLyu

Nicely done overall! The documentation is detailed and complete, and the game itself is fun to play. If you think about revising this project for MP5, I strongly suggest you explore MVC pattern and really clean up the code stylistically.

osteele · 2017-12-05T19:15:15Z

Game4.py

+                if event.type == pygame.KEYDOWN:
+                    # z to create obstacle at ground level
+                    if event.key == pygame.K_z:
+                        new_obstical = True


sp. new_obstacle

Consider using constants to document the levels:

GROUND_LEVEL_X_OFFSET = 0 FIRST_LEVEL_X_OFFSET = 25 SECOND_LEVEL_X_OFFSET = 50 … obstacle_height = obs_y - FIRST_LEVEL_X_OFFSET

The general principle is that you can name things instead of commenting them. The names are more likely to stay in sync with the code that the comments are, and are also evident everywhere the named thing is used.

You could also use e.g.

LEVEL_OFFSETS = { 'ground': 0, 'first': 25, 'second': 50, } … obstacle_height = obs_y - LEVEL_OFFSETS['first']

or:

LEVEL_OFFSETS = { 0: 0, 1: 25, 2: 50, } … obstacle_height = obs_y - LEVEL_OFFSETS[1]

LEVEL_OFFSETS = [0, 25, 50] … obstacle_height = obs_y - LEVEL_OFFSETS[1]

This makes it easier to add levels. It also allows for downstream simplifications, for example a map from event.key to level name or index.

osteele · 2017-12-05T19:21:34Z

Game4.py

+            pressed = pygame.key.get_pressed()
+            # up to jump
+            if pressed[pygame.K_UP] and P1_stamina_bar.bars >= player.jumpcost:
+                if  player.play_y == (360 - player.play_len):


360 is a “magic number”. Replace it by a constant, or an attribute that is initialized next to wherever this value is coming from.

osteele · 2017-12-05T19:22:00Z

Game4.py

+    def gameOver(self,score):
+        """Game over screen."""
+        # main event loop
+        while 1:


Again, while True is clearer.

osteele · 2017-12-05T19:24:34Z

Game4.py

+        while 1:
+            for event in pygame.event.get():
+                if event.type == pygame.QUIT:
+                    sys.exit()


Going beyond: you can also use either of the following. Experiment with these styles, and see if they're to your liking.

if any(event.type == pygame.QUIT for event in pygame.event.get()): sys.exit()

if pygame.QUIT in {event.type event in pygame.event.get()}: sys.exit()

({…} makes a set; same as set(…).)

osteele · 2017-12-05T19:25:58Z

Game4.py

+            # display game over screen
+            self.screen.fill(colors['BLACK'])
+            font = pygame.font.SysFont("comicsansms", 28)
+            text = font.render("Player 1 recived a score of " + str(score), True, (255,255,255))


(255,255,255) is a good candidate for a constant, especially as it's used more than once.

Think fragility and maintainability: it's easy to type (255,25,255) and not notice; and WHITE leaps out to the reader in a way that (255,255,255) does not.

osteele · 2017-12-05T19:26:30Z

misc.py

+    """A square obstacle, defined by its top left hand coordinate, length, and color.
+    Also takes in screen as an argument to draw the obstacle."""
+    def __init__(self, obs_x, obs_y, obs_len, screen, color):
+        """Initialize the instance."""


This comment isn't necessary.

osteele · 2017-12-05T19:27:42Z

misc.py

+        return 'Obstacle({}, {}, {}, {})'.format(self.obs_x, self.obs_y, self.obs_len, self.screen)
+
+    def moveForward(self):
+        """Update horizontal location and draw obstacle."""


Python convention is move_forward, is_gone.

move_forward_and_draw is a clearer description of this methods behavior. Separate move_forward and draw might be more naturally units, though.

osteele · 2017-12-05T19:30:08Z

misc.py

+        play_y0 = self.play_y
+        play_y1 = self.play_y + self.play_len
+        # check if player coordinates within obstacle coordinates
+        if (play_x0 in range(obs_x0, obs_x1) or play_x1 in range(obs_x0, obs_x1)) and (int(play_y0) in range(obs_y0, obs_y1) or int(play_y1) in range(obs_y0, obs_y1)):


Shortcut: if (obs_x0 <= play_x0 < obs_x1 or play_x1 <= play_x0 < obs_x1) …

vivienyuwenchen and others added 30 commits October 18, 2017 19:34

Create main game class

2de033a

Jumping Dot That Moves Side To Side

7d4d56a

Add player and keyboard control

7881c09

Merge branch 'master' of https://github.com/vivienyuwenchen/Interacti…

a72aed8

…veProgramming

Add player class, collision detection, and game over

ae5ded3

Added player summuned obsticals

035bf5d

Add stamina bar

860cf7c

player two spawns obsticals at different hights

dd67c71

merged

9f2156e

Ad project writeup and reflection

a98883f

added player 2 stamia bar

41fc448

Merge branch 'master' of https://github.com/vivienyuwenchen/Interacti…

757dba6

…veProgramming

Fix isCollide to work at different heights

7bab5b1

Change restart game key to space bar

0ede561

Add docstrings and comments

3d5ef9d

Fixed stamina bar regeneration

6b22ee8

Added score and changed endgame scene

d55ede1

Update project writeup and reflection

a4057a2

Add screenshots of game

c6a297c

Add screenshots of game

522df62

Update README.md

ea85407

Update project writeup and reflection

734db7c

Merge branch 'master' of https://github.com/vivienyuwenchen/Interacti…

4edcbf7

…veProgramming

Added Captions To figures

58d7c1b

Fixed Caption Spacing

af2ed11

Update inline comments

0f26809

Merge branch 'master' of https://github.com/vivienyuwenchen/Interacti…

c66f558

…veProgramming

Replace Barleft with Bar

dd5ea39

Added Player reviews

f877988

Added Player reviews

a896506

hthomas60 and others added 10 commits October 29, 2017 22:37

Added Player reviews

20ba136

Added Player reviews

d33d9c2

Added Player reviews

4441f05

Added Player reviews

6a55531

Added Player reviews

5fb8cc9

Same

ce5b8eb

Add UML diagram

886ec96

Merge branch 'master' of https://github.com/vivienyuwenchen/Interacti…

a8bfe17

…veProgramming

Add UML diagram

eea96f3

Update project writeup and reflection

b97a0c0

SeunginLyu reviewed Dec 3, 2017

View reviewed changes

Game4.py

@@ -0,0 +1,165 @@

import os, sys

Copy link

SeunginLyu Dec 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a few lines of comments explaining what this cool game is about!

SeunginLyu reviewed Dec 3, 2017

View reviewed changes

pygame_base_template.py Outdated

jumpover = False

#if False:#if detect_key_press() == 'space':

Copy link

SeunginLyu Dec 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove comments

SeunginLyu reviewed Dec 3, 2017

View reviewed changes

osteele reviewed Dec 5, 2017

View reviewed changes

Game4.py Outdated

def gameOver(self,score):

"""Game over screen."""

# main event loop

while 1:

Copy link

Contributor

osteele Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, while True is clearer.

osteele reviewed Dec 5, 2017

View reviewed changes

Revised for MP5 with suggestions from feedback and start menu

cea81cc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Complete interactive programming #3

Complete interactive programming #3

vivienyuwenchen commented Oct 30, 2017

SeunginLyu Dec 3, 2017

SeunginLyu Dec 3, 2017

osteele Dec 5, 2017

SeunginLyu Dec 3, 2017

SeunginLyu Dec 3, 2017 •

edited

Loading

osteele Dec 5, 2017

SeunginLyu Dec 3, 2017

SeunginLyu Dec 3, 2017

osteele Dec 5, 2017

SeunginLyu Dec 3, 2017

SeunginLyu left a comment

osteele Dec 5, 2017

osteele Dec 5, 2017

osteele Dec 5, 2017

osteele Dec 5, 2017

osteele Dec 5, 2017

osteele Dec 5, 2017

osteele Dec 5, 2017

osteele Dec 5, 2017

osteele Dec 5, 2017


		jumpover = False

		#if False:#if detect_key_press() == 'space':

Complete interactive programming #3

Are you sure you want to change the base?

Complete interactive programming #3

Conversation

vivienyuwenchen commented Oct 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SeunginLyu Dec 3, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SeunginLyu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SeunginLyu Dec 3, 2017 •

edited

Loading