Completed MP1 #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branchwelder
reviewed
Oct 8, 2017
branchwelder
left a comment
branchwelder
left a comment
There was a problem hiding this comment.
Great job! Your code is well formatted and easy to understand, you chose reasonable variable names, and solved the problems appropriately.
| """ | ||
| # TODO: implement this | ||
| pass | ||
| complement_list= [] #creating empty complement list |
There was a problem hiding this comment.
You don't need to comment every line - just comment the things that might be unclear to someone reading your code (or if you want to document something important).
| return orf | ||
| else: | ||
| orf = orf + codon | ||
| return dna[:] |
There was a problem hiding this comment.
dna means the same thing as dna[:]. Here you're essentially taking a slice of the whole string, when you could just return the string. (This doesn't change the meaning of your code at all, however.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yay